From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53352)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W34B6-0003CN-Ew
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 08:37:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W34Aw-0003O0-FT
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 08:37:12 -0500
Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:49810)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W34Aw-0003Np-7v
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 08:37:02 -0500
Received: by mail-pa0-f53.google.com with SMTP id lj1so1259163pab.40
	for <qemu-devel@nongnu.org>; Tue, 14 Jan 2014 05:37:01 -0800 (PST)
Date: Tue, 14 Jan 2014 21:36:57 +0800
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140114133657.GD2995@stefanha-thinkpad>
References: <20140109144123.21800.45879.stgit@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20140109144123.21800.45879.stgit@fimbulvetr.bsc.es>
Subject: Re: [Qemu-devel] [PATCH] trace: [simple] Do not include
 "trace/simple.h" in generated tracer headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Llu=EDs?= Vilanova <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Thu, Jan 09, 2014 at 03:41:23PM +0100, Lluís Vilanova wrote:
> diff --git a/trace/simple.c b/trace/simple.c
> index 1e3f691..8b59760 100644
> --- a/trace/simple.c
> +++ b/trace/simple.c
> @@ -8,6 +8,8 @@
>   *
>   */
>  
> +#include "trace/simple.h"
> +
>  #include <stdlib.h>
>  #include <stdint.h>
>  #include <stdio.h>

Please put user-defined header #includes (<>) below system header
#includes ("").  This ensures we don't define macros that affect system
headers.