* [Qemu-devel] [PATCH v2] trace: [simple] Do not include "trace/simple.h" in generated tracer headers
@ 2014-01-14 15:52 Lluís Vilanova
2014-01-15 1:51 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Lluís Vilanova @ 2014-01-14 15:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Stefan Hajnoczi, Stefan Hajnoczi
The header is not necessary, given that the simple backend does not define any
inlined tracing routines.
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
scripts/tracetool/backend/simple.py | 3 ---
trace/simple.c | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backend/simple.py
index 37ef599..30faac9 100644
--- a/scripts/tracetool/backend/simple.py
+++ b/scripts/tracetool/backend/simple.py
@@ -93,9 +93,6 @@ def c(events):
def h(events):
- out('#include "trace/simple.h"',
- '')
-
for event in events:
out('void trace_%(name)s(%(args)s);',
name = event.name,
diff --git a/trace/simple.c b/trace/simple.c
index 1e3f691..410172e 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -19,6 +19,7 @@
#include "qemu/timer.h"
#include "trace.h"
#include "trace/control.h"
+#include "trace/simple.h"
/** Trace file header event ID */
#define HEADER_EVENT_ID (~(uint64_t)0) /* avoids conflicting with TraceEventIDs */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] trace: [simple] Do not include "trace/simple.h" in generated tracer headers
2014-01-14 15:52 [Qemu-devel] [PATCH v2] trace: [simple] Do not include "trace/simple.h" in generated tracer headers Lluís Vilanova
@ 2014-01-15 1:51 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2014-01-15 1:51 UTC (permalink / raw)
To: Lluís Vilanova; +Cc: Stefan Hajnoczi, qemu-devel
On Tue, Jan 14, 2014 at 04:52:55PM +0100, Lluís Vilanova wrote:
> The header is not necessary, given that the simple backend does not define any
> inlined tracing routines.
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> scripts/tracetool/backend/simple.py | 3 ---
> trace/simple.c | 1 +
> 2 files changed, 1 insertion(+), 3 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-15 1:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-14 15:52 [Qemu-devel] [PATCH v2] trace: [simple] Do not include "trace/simple.h" in generated tracer headers Lluís Vilanova
2014-01-15 1:51 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).