From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3JKm-0001df-6I for qemu-devel@nongnu.org; Wed, 15 Jan 2014 00:48:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3JKh-0005zD-NE for qemu-devel@nongnu.org; Wed, 15 Jan 2014 00:48:12 -0500 Date: Wed, 15 Jan 2014 15:47:31 +1000 From: "Edgar E. Iglesias" Message-ID: <20140115054731.GA29496@edvb> References: <1385538611-8149-1-git-send-email-sebastian.huber@embedded-brains.de> <52A20DF6.9070801@twiddle.net> <52CC4250.2060107@embedded-brains.de> <52D4E188.6080704@embedded-brains.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <52D4E188.6080704@embedded-brains.de> Subject: Re: [Qemu-devel] [PATCH v2] SPARC: Fix LEON3 power down instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Huber Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Tue, Jan 14, 2014 at 08:04:40AM +0100, Sebastian Huber wrote: > Hello, > > maybe this patch can be qualified as trivial? Hi, I've applied it, thanks. Cheers, Edgar > > http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg03488.html > > On 2014-01-07 19:07, Sebastian Huber wrote: > >Hello, > > > >would somebody mind committing this. > > > >On 12/06/2013 06:48 PM, Richard Henderson wrote: > >>On 11/27/2013 08:50 PM, Sebastian Huber wrote: > >>>Synchronize the program counter before the power down helper call > >>>otherwise interrupts will return to the wrong context. > >>> > >>>Signed-off-by: Sebastian Huber > >>>--- > >>> target-sparc/translate.c | 1 + > >>> 1 files changed, 1 insertions(+), 0 deletions(-) > >>> > >>>diff --git a/target-sparc/translate.c b/target-sparc/translate.c > >>>index 05639ef..7481c85 100644 > >>>--- a/target-sparc/translate.c > >>>+++ b/target-sparc/translate.c > >>>@@ -3630,6 +3630,7 @@ static void disas_sparc_insn(DisasContext * dc, > >>>unsigned int insn) > >>> if ((rd == 0x13) && (dc->def->features & > >>> > >>>CPU_FEATURE_POWERDOWN)) { > >>> /* LEON3 power-down */ > >>>+ save_state(dc); > >>> gen_helper_power_down(cpu_env); > >>> } > >>> break; > >>> > >>Reviewed-by: Richard Henderson > >> > >> > >>r~ > >> > > > > > > > -- > Sebastian Huber, embedded brains GmbH > > Address : Dornierstr. 4, D-82178 Puchheim, Germany > Phone : +49 89 189 47 41-16 > Fax : +49 89 189 47 41-09 > E-Mail : sebastian.huber@embedded-brains.de > PGP : Public key available on request. > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. >