From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58601)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W3Jwh-0001wb-2c
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 01:27:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W3Jwa-0007YZ-Jo
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 01:27:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:62495)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W3Jwa-0007YK-C0
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 01:27:16 -0500
Date: Wed, 15 Jan 2014 14:27:05 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140115062705.GB25475@T430.nay.redhat.com>
References: <1389608518-4813-1-git-send-email-pl@kamp.de>
	<1389608518-4813-7-git-send-email-pl@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1389608518-4813-7-git-send-email-pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCHv6 6/6] qemu-iotests: blacklist test 020 for
	NFS protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>, ronniesahlberg@gmail.com, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>, owasserm@redhat.com, Federico Simoncelli <fsimonce@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

On Mon, 01/13 11:21, Peter Lieven wrote:
> reopening is currently not supported.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  tests/qemu-iotests/020 |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020
> index a42f32f..f8a849c 100755
> --- a/tests/qemu-iotests/020
> +++ b/tests/qemu-iotests/020
> @@ -46,6 +46,11 @@ _supported_fmt qcow qcow2 vmdk qed
>  _supported_proto file
>  _supported_os Linux
>  
> +# NFS does not support bdrv_reopen_prepare thus qemu-img commit fails.
> +if [ "$IMGPROTO" = "nfs" ]; then
> +    _notrun "image protocol $IMGPROTO does not support bdrv_commit"
> +fi
> +

Doesn't "_supported_proto file" above already skip this case?

Fam