From: Igor Mammedov <imammedo@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: edgar.iglesias@xilinx.com, armbru@redhat.com,
qemu-devel@nongnu.org, afaerber@suse.de, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 1/2] tests: Add libqemustub to qom-interface-check
Date: Wed, 15 Jan 2014 13:03:00 +0100 [thread overview]
Message-ID: <20140115130300.3eb9d53f@thinkpad> (raw)
In-Reply-To: <f8ba2152487d524ee0dc4dd493602aa0be1afa1c.1389783548.git.peter.crosthwaite@xilinx.com>
On Wed, 15 Jan 2014 03:05:36 -0800
Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> The recent addition of util/error.c's dependency on error_report()
> causes this test to fail to link due to a number of missing monitor
> related symbols. All these symbols are however defined by libqemustub.
> Add this libary to the link.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 0aaf657..fd36eee 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -151,7 +151,7 @@ tests/check-qdict$(EXESUF): tests/check-qdict.o libqemuutil.a
> tests/check-qlist$(EXESUF): tests/check-qlist.o libqemuutil.a
> tests/check-qfloat$(EXESUF): tests/check-qfloat.o libqemuutil.a
> tests/check-qjson$(EXESUF): tests/check-qjson.o libqemuutil.a libqemustub.a
> -tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(qom-core-obj) libqemuutil.a
> +tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(qom-core-obj) libqemuutil.a libqemustub.a
> tests/test-coroutine$(EXESUF): tests/test-coroutine.o $(block-obj-y) libqemuutil.a libqemustub.a
> tests/test-aio$(EXESUF): tests/test-aio.o $(block-obj-y) libqemuutil.a libqemustub.a
> tests/test-throttle$(EXESUF): tests/test-throttle.o $(block-obj-y) libqemuutil.a libqemustub.a
> --
> 1.8.5.3
>
Reviewed-By: Igor Mammedov <imammedo@redhat.com>
--
Regards,
Igor
prev parent reply other threads:[~2014-01-15 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 11:05 [Qemu-devel] [PATCH v1 1/2] tests: Add libqemustub to qom-interface-check Peter Crosthwaite
2014-01-15 11:06 ` [Qemu-devel] [PATCH v1 2/2] Revert "error: Don't use error_report() for assertion msgs." Peter Crosthwaite
2014-01-28 2:35 ` Peter Crosthwaite
2014-01-28 2:36 ` Edgar E. Iglesias
2014-01-28 7:34 ` Markus Armbruster
2014-01-29 20:45 ` Peter Maydell
2014-01-30 8:00 ` Markus Armbruster
2014-02-16 20:56 ` Peter Maydell
2014-01-15 12:03 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115130300.3eb9d53f@thinkpad \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=lcapitulino@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).