From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1W3PBi-0007Tz-FS
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:03:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1W3PBc-0006J4-Lc
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:03:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53463)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1W3PBc-0006IV-EF
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:03:08 -0500
Date: Wed, 15 Jan 2014 13:03:00 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140115130300.3eb9d53f@thinkpad>
In-Reply-To: <f8ba2152487d524ee0dc4dd493602aa0be1afa1c.1389783548.git.peter.crosthwaite@xilinx.com>
References: <f8ba2152487d524ee0dc4dd493602aa0be1afa1c.1389783548.git.peter.crosthwaite@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 1/2] tests: Add libqemustub to
	qom-interface-check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: edgar.iglesias@xilinx.com, armbru@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de, lcapitulino@redhat.com

On Wed, 15 Jan 2014 03:05:36 -0800
Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:

> The recent addition of util/error.c's dependency on error_report()
> causes this test to fail to link due to a number of missing monitor
> related symbols. All these symbols are however defined by libqemustub.
> Add this libary to the link.
> 
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> 
>  tests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 0aaf657..fd36eee 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -151,7 +151,7 @@ tests/check-qdict$(EXESUF): tests/check-qdict.o libqemuutil.a
>  tests/check-qlist$(EXESUF): tests/check-qlist.o libqemuutil.a
>  tests/check-qfloat$(EXESUF): tests/check-qfloat.o libqemuutil.a
>  tests/check-qjson$(EXESUF): tests/check-qjson.o libqemuutil.a libqemustub.a
> -tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(qom-core-obj) libqemuutil.a
> +tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(qom-core-obj) libqemuutil.a libqemustub.a
>  tests/test-coroutine$(EXESUF): tests/test-coroutine.o $(block-obj-y) libqemuutil.a libqemustub.a
>  tests/test-aio$(EXESUF): tests/test-aio.o $(block-obj-y) libqemuutil.a libqemustub.a
>  tests/test-throttle$(EXESUF): tests/test-throttle.o $(block-obj-y) libqemuutil.a libqemustub.a
> -- 
> 1.8.5.3
> 

Reviewed-By: Igor Mammedov <imammedo@redhat.com>

-- 
Regards,
  Igor