From: Kevin O'Connor <kevin@koconnor.net>
To: marcel.a@redhat.com
Cc: mst@redhat.com, ghammer@redhat.com, seabios@seabios.org,
qemu-devel@nongnu.org, kraxel@redhat.com, lersek@redhat.com
Subject: Re: [Qemu-devel] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume
Date: Wed, 15 Jan 2014 11:04:55 -0500 [thread overview]
Message-ID: <20140115160455.GA9300@morn.localdomain> (raw)
In-Reply-To: <1389788680.29856.16.camel@localhost.localdomain>
On Wed, Jan 15, 2014 at 02:24:40PM +0200, Marcel Apfelbaum wrote:
> On Wed, 2014-01-15 at 14:20 +0200, Marcel Apfelbaum wrote:
> > On resume, the OS queries the power management event that
> > caused it. In order to complete this task, it executes some
> > reads to the piix pm io space. This all happens before the
> > OS has a chance to restore the PCI config space for devices,
> > so it is bios's responsibility to make sure the pm IO space
> > is configured correctly. (During suspend, the piix pm
> > configuration space is lost).
> >
> > Note: For 'ordinary' pci devices the config space is
> > saved by the OS on sleep and restored on resume.
> >
> > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
>
> Ooops! I put a [Qemu-devel] prefix, it is going to be a problem?
I fixed it up. The patch also had two header files declaring
pci_resume() - I fixed that up as well. It's been committed.
Thanks.
-Kevin
next prev parent reply other threads:[~2014-01-15 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 12:20 [Qemu-devel] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume Marcel Apfelbaum
2014-01-15 12:24 ` Marcel Apfelbaum
2014-01-15 16:04 ` Kevin O'Connor [this message]
2014-01-15 15:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115160455.GA9300@morn.localdomain \
--to=kevin@koconnor.net \
--cc=ghammer@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).