From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bligh" <alex@alex.org.uk>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Miroslav Rezanina" <mrezanin@redhat.com>,
"Lluís Vilanova" <vilanova@ac.upc.edu>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading
Date: Thu, 16 Jan 2014 09:11:16 +0800 [thread overview]
Message-ID: <20140116011116.GC2073@T430.nay.redhat.com> (raw)
In-Reply-To: <52D67F7F.9030709@redhat.com>
On Wed, 01/15 13:30, Paolo Bonzini wrote:
> Il 15/01/2014 13:18, Alex Bligh ha scritto:
> > I phrased that badly. I meant same output for the same calling convention, so
> > surely just replacing 'sha256sum' with 'shasum -a 256' is going to work fine on
> > all systems?
>
> I don't think all systems are guaranteed to have shasum. If we use
> SHA-1, and just look for the three binaries sha1sum/sha1/shasum, we
> don't have to bother about arguments and only add 10 lines or so to
> configure.
>
Agreed. I'll add a test and probe for any one of shasum, sha256 and sha256sum.
Easy enough.
Fam
next prev parent reply other threads:[~2014-01-16 1:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 8:48 [Qemu-devel] [PATCH v16 0/9] Shared library module support Fam Zheng
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 1/9] rules.mak: fix $(obj) to a real relative path Fam Zheng
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs Fam Zheng
2014-01-15 19:35 ` Peter Maydell
2014-01-16 10:53 ` Fam Zheng
2014-01-16 11:04 ` Peter Maydell
2014-01-16 12:40 ` Fam Zheng
2014-01-16 12:43 ` Paolo Bonzini
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 3/9] block: use per-object " Fam Zheng
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 4/9] darwin: do not use -mdynamic-no-pic Fam Zheng
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 5/9] build-sys: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 6/9] module: implement module loading Fam Zheng
2014-01-15 11:53 ` Peter Maydell
2014-01-15 11:56 ` Paolo Bonzini
2014-01-15 12:03 ` Peter Maydell
2014-01-15 12:05 ` Paolo Bonzini
2014-01-15 12:11 ` Peter Maydell
2014-01-15 12:17 ` Paolo Bonzini
2014-01-15 12:09 ` Alex Bligh
2014-01-15 12:10 ` Paolo Bonzini
2014-01-15 12:18 ` Alex Bligh
2014-01-15 12:30 ` Paolo Bonzini
2014-01-16 1:11 ` Fam Zheng [this message]
2014-01-15 12:34 ` Fam Zheng
2014-01-15 12:38 ` Paolo Bonzini
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 7/9] Makefile: install modules with "make install" Fam Zheng
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 8/9] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2014-01-15 8:48 ` [Qemu-devel] [PATCH v16 9/9] block: convert block drivers linked with libs to modules Fam Zheng
2014-01-15 13:11 ` [Qemu-devel] [PATCH v16 0/9] Shared library module support Peter Maydell
2014-01-15 14:11 ` Paolo Bonzini
2014-01-15 14:20 ` Peter Maydell
2014-01-15 14:36 ` Paolo Bonzini
2014-01-15 14:40 ` Peter Maydell
2014-01-15 14:51 ` Paolo Bonzini
2014-01-15 15:29 ` Peter Maydell
2014-01-15 15:40 ` Peter Maydell
2014-01-15 16:14 ` Paolo Bonzini
2014-01-16 1:16 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116011116.GC2073@T430.nay.redhat.com \
--to=famz@redhat.com \
--cc=alex@alex.org.uk \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mrezanin@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).