From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3bUj-0004UK-Ca for qemu-devel@nongnu.org; Wed, 15 Jan 2014 20:11:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3bUd-0004Iz-CB for qemu-devel@nongnu.org; Wed, 15 Jan 2014 20:11:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3bUd-0004Iv-4l for qemu-devel@nongnu.org; Wed, 15 Jan 2014 20:11:35 -0500 Date: Thu, 16 Jan 2014 09:11:16 +0800 From: Fam Zheng Message-ID: <20140116011116.GC2073@T430.nay.redhat.com> References: <1389775713-996-1-git-send-email-famz@redhat.com> <1389775713-996-7-git-send-email-famz@redhat.com> <52D6775B.9000704@redhat.com> <54FD93F5-AA4D-4787-8B60-05FD49BC2B5C@alex.org.uk> <52D67AB2.70801@redhat.com> <52D67F7F.9030709@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52D67F7F.9030709@redhat.com> Subject: Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Peter Maydell , Alex Bligh , Michael Tokarev , QEMU Developers , Stefan Hajnoczi , Miroslav Rezanina , =?iso-8859-1?Q?Llu=EDs?= Vilanova , Richard Henderson On Wed, 01/15 13:30, Paolo Bonzini wrote: > Il 15/01/2014 13:18, Alex Bligh ha scritto: > > I phrased that badly. I meant same output for the same calling convention, so > > surely just replacing 'sha256sum' with 'shasum -a 256' is going to work fine on > > all systems? > > I don't think all systems are guaranteed to have shasum. If we use > SHA-1, and just look for the three binaries sha1sum/sha1/shasum, we > don't have to bother about arguments and only add 10 lines or so to > configure. > Agreed. I'll add a test and probe for any one of shasum, sha256 and sha256sum. Easy enough. Fam