From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3gwl-00071g-Dl for qemu-devel@nongnu.org; Thu, 16 Jan 2014 02:01:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3gwg-0007Vl-2e for qemu-devel@nongnu.org; Thu, 16 Jan 2014 02:00:59 -0500 Received: from mail-ee0-x235.google.com ([2a00:1450:4013:c00::235]:56148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3gwf-0007Vf-S9 for qemu-devel@nongnu.org; Thu, 16 Jan 2014 02:00:53 -0500 Received: by mail-ee0-f53.google.com with SMTP id t10so1309261eei.12 for ; Wed, 15 Jan 2014 23:00:52 -0800 (PST) Date: Thu, 16 Jan 2014 15:00:23 +0800 From: Stefan Hajnoczi Message-ID: <20140116070023.GA23834@stefanha-thinkpad.redhat.com> References: <2fb3ea05d2e1ee06d578a0f2c53f56df1661401c.1389726691.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fb3ea05d2e1ee06d578a0f2c53f56df1661401c.1389726691.git.jcody@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Jan 14, 2014 at 02:12:19PM -0500, Jeff Cody wrote: > Having both read-only=on and snapshot=on together does not make sense; > currently, the read-only argument is effectively ignored for the > temporary snapshot. To prevent confusion, disallow the usage of both > 'snapshot=on' and 'read-only=on'. > > Signed-off-by: Jeff Cody > --- > blockdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan