qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	patches@linaro.org, qemu-devel@nongnu.org,
	qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface
Date: Thu, 16 Jan 2014 10:52:11 +0100	[thread overview]
Message-ID: <20140116095211.GB3369@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <20140116092456.GE13802@redhat.com>

Am 16.01.2014 um 10:24 hat Richard W.M. Jones geschrieben:
> 
> On further investigation, the "No such file or directory" error occurs
> when using snapshot=on.
> 
> ie:
> 
> This fails:
> 
> ./x86_64-softmmu/qemu-system-x86_64 -drive 'file=http://127.0.0.1/~rjones/cirros-0.3.1-x86_64-disk.img,if=virtio,snapshot=on'
> 
> This works:
> 
> ./x86_64-softmmu/qemu-system-x86_64 -drive 'file=http://127.0.0.1/~rjones/cirros-0.3.1-x86_64-disk.img,if=virtio,readonly=on'

Whoops, sorry, I think it was me who broke this when I rewrote
snapshot=on support to fit better in the whole blockdev-add
infrastructure (commit 9fd3171a).

The reason is that instead of writing the file name into the backing
file header field of the temporary image, it now uses the file.filename
runtime option, which doesn't parse protocol names from the filename.

I believe Max was going to look into some related issues (basically how
to get rid of the "magic" filenames in the core code without breaking
compatibility), perhaps a fix comes out naturally from such changes.

Workaround for now: Add an explicit file.driver=http

Kevin

  reply	other threads:[~2014-01-16  9:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 17:23 [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface Peter Maydell
2014-01-15 21:37 ` Richard W.M. Jones
2014-01-15 21:56   ` Peter Maydell
2014-01-16  8:40     ` Paolo Bonzini
2014-01-15 22:06 ` Paolo Bonzini
2014-01-15 22:15   ` Peter Maydell
2014-01-16  8:38     ` Paolo Bonzini
2014-01-16  9:55       ` Peter Maydell
2014-01-16 10:15         ` Paolo Bonzini
2014-01-16  9:12   ` Richard W.M. Jones
2014-01-16  9:24     ` Richard W.M. Jones
2014-01-16  9:52       ` Kevin Wolf [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-01-24 13:56 Paolo Bonzini
2014-01-24 15:01 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116095211.GB3369@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).