From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3k11-00024J-Ho for qemu-devel@nongnu.org; Thu, 16 Jan 2014 05:17:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3k0x-0006Ze-Of for qemu-devel@nongnu.org; Thu, 16 Jan 2014 05:17:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3k0x-0006ZS-Gd for qemu-devel@nongnu.org; Thu, 16 Jan 2014 05:17:31 -0500 Date: Thu, 16 Jan 2014 10:17:17 +0000 From: "Daniel P. Berrange" Message-ID: <20140116101717.GD29231@redhat.com> References: <1389172376-30636-1-git-send-email-lilei@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1389172376-30636-1-git-send-email-lilei@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH resend 0/6 RFC] Provide common methods for exchange FD Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: pbonzini@redhat.com, mohan@in.ibm.com, qemu-devel@nongnu.org On Wed, Jan 08, 2014 at 05:12:50PM +0800, Lei Li wrote: > This patch series tries to refactor the functions used for > exchange of FD in current code, provide common methods > for it. > > The series is based on the localhost migration with side channel > for ram series as it was already a good shape. But if you want > to merge this first, I'll get rid of the migration part. > > I just tested page flipping migration, and tap/bridge-helper a > bit, but have some environment problem on proxy fs driver. So > it'd be appreciated if someone could help on verifying whether > it has impact on it. :) > > Please let me know if there is anything needs to be improved. This looks like a good improvement to me, aside from a couple of small bugs. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|