From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3jPk-0000Pp-Us for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:39:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3jPg-00037Z-Fk for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:39:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3jPg-00037U-7Z for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:39:00 -0500 Date: Thu, 16 Jan 2014 10:38:53 +0100 From: Igor Mammedov Message-ID: <20140116103853.0409dcb2@nial.usersys.redhat.com> In-Reply-To: <20140116093337.GA21814@redhat.com> References: <1389718554-2387-1-git-send-email-imammedo@redhat.com> <20140116093337.GA21814@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/9 v4] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.crosthwaite@xilinx.com, marcel.a@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de On Thu, 16 Jan 2014 11:33:37 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 14, 2014 at 05:55:45PM +0100, Igor Mammedov wrote: > > changes since v3: > > - fixup/add comments as reqused by Peter Crosthwaite > > - use error_abort to reduce error handling verbosity > > - fix tests/test-qdev-global-props build failure on make check > > - rebase on top of current master:133fe7743 (with interface fixes) > > > > Reference to previous version: > > http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg02461.html > > Please add actual content to cover letters. > I see it was there in the previous version. I'll do it further on. > Also pl use --subject-prefix or (with recent git) -v flag so that all > patches are versioned, not just the cover letter. ok, thanks for a tip. > > > git tree for testing: > > https://github.com/imammedo/qemu/commits/hotplug_dev_inf_v4 > > > > Igor Mammedov (9): > > define hotplug interface > > qdev: add to BusState "hotplug-handler" link > > qdev: add "hotpluggable" property to Device > > hw/acpi: move typeinfo to the file end > > qdev:pci: refactor PCIDevice to use generic "hotpluggable" property > > acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API > > pci/shpc: convert SHPC hotplug to use hotplug-handler API > > pci/pcie: convert PCIE hotplug to use hotplug-handler API > > hw/pci: switch to a generic hotplug handling for PCIDevice > > > > hw/acpi/piix4.c | 156 ++++++++++++++++++++-------------------- > > hw/core/Makefile.objs | 1 + > > hw/core/hotplug.c | 48 ++++++++++++ > > hw/core/qdev.c | 50 ++++++++++++- > > hw/display/cirrus_vga.c | 2 +- > > hw/display/qxl.c | 2 +- > > hw/display/vga-pci.c | 2 +- > > hw/display/vmware_vga.c | 2 +- > > hw/i386/acpi-build.c | 6 +- > > hw/ide/piix.c | 4 +- > > hw/isa/piix4.c | 2 +- > > hw/pci-bridge/pci_bridge_dev.c | 9 +++ > > hw/pci-host/piix.c | 6 +- > > hw/pci/pci.c | 40 +---------- > > hw/pci/pcie.c | 67 +++++++++++------- > > hw/pci/pcie_port.c | 8 ++ > > hw/pci/shpc.c | 127 ++++++++++++++++++++------------ > > hw/usb/hcd-ehci-pci.c | 2 +- > > hw/usb/hcd-ohci.c | 2 +- > > hw/usb/hcd-uhci.c | 2 +- > > hw/usb/hcd-xhci.c | 2 +- > > include/hw/hotplug.h | 78 ++++++++++++++++++++ > > include/hw/pci/pci.h | 13 ---- > > include/hw/pci/pci_bus.h | 2 - > > include/hw/pci/pcie.h | 5 ++ > > include/hw/pci/shpc.h | 8 ++ > > include/hw/qdev-core.h | 8 ++ > > tests/Makefile | 2 +- > > 28 files changed, 432 insertions(+), 224 deletions(-) > > create mode 100644 hw/core/hotplug.c > > create mode 100644 include/hw/hotplug.h