From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3koB-0002TP-2d for qemu-devel@nongnu.org; Thu, 16 Jan 2014 06:08:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3ko5-0004bs-2e for qemu-devel@nongnu.org; Thu, 16 Jan 2014 06:08:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3ko4-0004bm-Qi for qemu-devel@nongnu.org; Thu, 16 Jan 2014 06:08:16 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GB8GoN000959 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Jan 2014 06:08:16 -0500 Date: Thu, 16 Jan 2014 13:08:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20140116110814.GA28948@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] tests: require that acpi tests are enabled explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum ACPI code is changing as bit too fast to make it worth it to require everyone to check it against expected output. Make test run depend on an ACPI_TEST_EXPECTED_AML set in environment, so interested people can run it without affecting everyone. Signed-off-by: Michael S. Tsirkin --- I'd like to prevent tests failing for everyone each time we change some ACPI code. This is an inelegant way to do this, would be better to emit a warning and keep going. tests/acpi-test.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index b5ab70a..c164382 100644 --- a/tests/acpi-test.c +++ b/tests/acpi-test.c @@ -22,6 +22,7 @@ #define MACHINE_PC "pc" #define MACHINE_Q35 "q35" +#define ACPI_TEST_EXPECTED_AML "TEST_ACPI_TEST_AML" #define ACPI_REBUILD_EXPECTED_AML "TEST_ACPI_REBUILD_AML" /* DSDT and SSDTs format */ @@ -572,7 +573,10 @@ static void test_acpi_one(const char *params, test_data *data) test_acpi_dsdt_table(data); test_acpi_ssdt_tables(data); - if (iasl) { + if (getenv(ACPI_TEST_EXPECTED_AML)) { + + g_assert(iasl); + if (getenv(ACPI_REBUILD_EXPECTED_AML)) { dump_aml_files(data, true); } else { -- MST