From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3mR4-0006nA-I3 for qemu-devel@nongnu.org; Thu, 16 Jan 2014 07:52:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3mQx-0002zI-H4 for qemu-devel@nongnu.org; Thu, 16 Jan 2014 07:52:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3mQx-0002z9-9H for qemu-devel@nongnu.org; Thu, 16 Jan 2014 07:52:31 -0500 Date: Thu, 16 Jan 2014 13:52:25 +0100 From: Kevin Wolf Message-ID: <20140116125225.GE3369@dhcp-200-207.str.redhat.com> References: <1386148259-10962-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1386148259-10962-4-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386148259-10962-4-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V7 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 04.12.2013 um 10:10 hat Wenchao Xia geschrieben: > This case can't run when IMGPROTO=nbd, since it needs to create some > internal snapshot which would fail for EOF write request, even when > TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto > to file. > > _require_command() is changed to tip what util is missing, instead > of printing a blank. > > Signed-off-by: Wenchao Xia > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -64,6 +64,7 @@ > 055 rw auto > 056 rw auto backing > 057 rw auto > +058 rw auto > 059 rw auto > 060 rw auto > 061 rw auto Please, please, please, stop doing this. If you see a hole in the numbering of test cases, it is because there are yet unmerged patches that use this number. The only thing you achieve by filling up the hole is merge conflicts. I have branches that regularly require manual conflict resolution because people think they are clever when they fill up holes. Simply add your cases to the end of the file, okay? (And up to 078 is taken now, if someone needs to assign a new test number for his patch.) Kevin