From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1W403v-00062s-Sx
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 22:25:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1W403p-0000dv-Kt
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 22:25:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11512)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1W403p-0000dp-7o
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 22:25:33 -0500
Date: Fri, 17 Jan 2014 11:25:21 +0800
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140117032521.GB16061@stefanha-thinkpad.redhat.com>
References: <1389435213-4378-1-git-send-email-b.galvani@gmail.com>
	<1389435213-4378-2-git-send-email-b.galvani@gmail.com>
	<CAEgOgz477cTR-Wj6n-cWnv3+Uduan0nMfD37GXL=xX5SYO5_mg@mail.gmail.com>
	<CAEgOgz5c1i9X8DHXvnOXYF+1N6k77wYOAYf5CaqRAbYnY5zPXw@mail.gmail.com>
	<20140114051938.GC4803@stefanha-thinkpad.redhat.com>
	<CAEgOgz6cR06LRLwy24m0rj+eZEh9tfa5YsD0+wTM6JsWHpgFuA@mail.gmail.com>
	<20140116024511.GA11535@stefanha-thinkpad>
	<CAEgOgz4h=M1HEKcSDMt1xikbnoRDeWOx6eZGTv93bZ5YGHUSbA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEgOgz4h=M1HEKcSDMt1xikbnoRDeWOx6eZGTv93bZ5YGHUSbA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner
 EMAC Fast Ethernet controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Peter Maydell <peter.maydell@linaro.org>, Juan Quintela <quintela@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Beniamino Galvani <b.galvani@gmail.com>, Li Guang <lig.fnst@cn.fujitsu.com>

On Thu, Jan 16, 2014 at 10:52:19PM +1000, Peter Crosthwaite wrote:
> > Perhaps we should just rely on
> > NetClient->link_ok.
> >
> 
> I think we are in agreement then? There is no need for phy.link_ok as
> same information is captured in NetClient. This means there is no
> link_ok field to migrate. Just migrate the phy registers themselves.
> 
> For completeness you just need to poll NetClient state post_load which
> will nicely handle my degenerate case of link activity between save
> and load (same handler as link_state_changed). In the more usual case
> of the link state not changing between save and load, this function
> call will just be a nop, leading to no change of state on the freshly
> migrated phy registers.

Sounds good.

Stefan