From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: marcel.a@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org,
Vincenzo Maffione <v.maffione@gmail.com>,
lcapitulino@redhat.com, aliguori@amazon.com, dmitry@daynix.com,
pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it
Subject: Re: [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function
Date: Fri, 17 Jan 2014 11:29:39 +0800 [thread overview]
Message-ID: <20140117032939.GD16061@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20140116092933.GA21761@redhat.com>
On Thu, Jan 16, 2014 at 11:29:34AM +0200, Michael S. Tsirkin wrote:
> On Tue, Jan 14, 2014 at 11:59:46AM +0100, Vincenzo Maffione wrote:
> > This function was used to set the using_vnet_hdr field into the
> > TAPState struct. However, it is always called immediately before
> > (see virtio-net.c) or immediately after (see vmxnet3.c) the function
> > tap_set_vnet_hdr_len(). It's therefore possible to set the
> > using_vnet_hdr field directly in tap_set_vnet_hdr_len() and remove
> > tap_using_vnet_hdr(), making the code simpler.
> >
> > Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
>
>
> virtio net only calls tap_set_vnet_hdr_len if tap_has_vnet_hdr_len
> returns true.
> I think this patch will break old linux hosts which don't support
> modifying vnet_hdr_len.
This is a good point. Let's leave the API alone then.
Stefan
next prev parent reply other threads:[~2014-01-17 3:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 10:59 [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 1/6] net: change vnet-hdr TAP prototypes Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function Vincenzo Maffione
2014-01-16 8:39 ` Stefan Hajnoczi
2014-01-16 9:29 ` Michael S. Tsirkin
2014-01-17 3:29 ` Stefan Hajnoczi [this message]
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 3/6] net: extend NetClientInfo for offloading manipulations Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 4/6] net: TAP uses NetClientInfo offloading callbacks Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 5/6] net: virtio-net and vmxnet3 use offloading API Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 6/6] net: add offloadings support to netmap backend Vincenzo Maffione
2014-01-15 6:49 ` [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support Barak Wasserstrom
2014-01-16 9:08 ` Stefan Hajnoczi
2014-01-16 15:00 ` Vincenzo Maffione
2014-01-17 3:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117032939.GD16061@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@amazon.com \
--cc=dmitry@daynix.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).