From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1W4IT9-0005Ba-3H
	for qemu-devel@nongnu.org; Fri, 17 Jan 2014 18:05:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1W4IT3-0008RR-Tl
	for qemu-devel@nongnu.org; Fri, 17 Jan 2014 18:04:55 -0500
Received: from paradis.irqsave.net ([62.212.105.220]:47752)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1W4IT3-0008R3-Ck
	for qemu-devel@nongnu.org; Fri, 17 Jan 2014 18:04:49 -0500
Date: Fri, 17 Jan 2014 23:49:41 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140117224941.GD7739@irqsave.net>
References: <1389968119-24771-1-git-send-email-kwolf@redhat.com>
	<1389968119-24771-5-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1389968119-24771-5-git-send-email-kwolf@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 04/29] qemu_memalign: Allow small
 alignments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com

Le Friday 17 Jan 2014 =E0 15:14:54 (+0100), Kevin Wolf a =E9crit :
> The functions used by qemu_memalign() require an alignment that is at
> least sizeof(void*). Adjust it if it is too small.
>=20
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
>  util/oslib-posix.c | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index e00a44c..54f8932 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -85,6 +85,11 @@ void *qemu_oom_check(void *ptr)
>  void *qemu_memalign(size_t alignment, size_t size)
>  {
>      void *ptr;
> +
> +    if (alignment < sizeof(void*)) {
> +        alignment =3D sizeof(void*);
> +    }
> +
>  #if defined(_POSIX_C_SOURCE) && !defined(__sun__)
>      int ret;
>      ret =3D posix_memalign(&ptr, alignment, size);
> --=20
> 1.8.1.4
>=20
>=20
Reviewed-by: Beno=EEt Canet <benoit@irqsave.net>