From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>,
qemu-devel@nongnu.org, Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries
Date: Mon, 20 Jan 2014 10:10:22 +0100 [thread overview]
Message-ID: <20140120091022.GA3267@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <20140117074015.GA31039@stefanha-thinkpad.redhat.com>
Am 17.01.2014 um 08:40 hat Stefan Hajnoczi geschrieben:
> On Mon, Dec 30, 2013 at 04:00:17PM +0800, Hu Tao wrote:
> > Fix incorrect bits of offsets in refcount table entry, l1 table
> > entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK
> > and L2E_OFFSET_MASK.
> >
> > Fix a typo while at the file.
> >
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > ---
> >
> > v2: update comments as well.
> >
> > docs/specs/qcow2.txt | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block
This patch is wrong. It's the qcow2.h #defines that need to be fixed,
not the spec. The smallest possible cluster size is 512 bytes, i.e.
nine zero bits at the end, not just eight.
Kevin
next prev parent reply other threads:[~2014-01-20 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 8:00 [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries Hu Tao
2014-01-17 7:40 ` Stefan Hajnoczi
2014-01-20 9:10 ` Kevin Wolf [this message]
2014-01-21 2:56 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120091022.GA3267@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).