From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5AsK-0000bN-TQ
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 04:10:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5AsG-0005u7-NF
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 04:10:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5AsG-0005tc-F9
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 04:10:28 -0500
Date: Mon, 20 Jan 2014 10:10:22 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140120091022.GA3267@dhcp-200-207.str.redhat.com>
References: <1388390417-14381-1-git-send-email-hutao@cn.fujitsu.com>
	<20140117074015.GA31039@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140117074015.GA31039@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect
 bits of offsets in entries
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org, Stefan Weil <sw@weilnetz.de>

Am 17.01.2014 um 08:40 hat Stefan Hajnoczi geschrieben:
> On Mon, Dec 30, 2013 at 04:00:17PM +0800, Hu Tao wrote:
> > Fix incorrect bits of offsets in refcount table entry, l1 table
> > entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK
> > and L2E_OFFSET_MASK.
> > 
> > Fix a typo while at the file.
> > 
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > ---
> > 
> > v2: update comments as well.
> > 
> >  docs/specs/qcow2.txt | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block

This patch is wrong. It's the qcow2.h #defines that need to be fixed,
not the spec. The smallest possible cluster size is 512 bytes, i.e.
nine zero bits at the end, not just eight.

Kevin