From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] acpi unit-test: fixes and improvements
Date: Mon, 20 Jan 2014 11:35:49 +0200 [thread overview]
Message-ID: <20140120093549.GA8434@redhat.com> (raw)
In-Reply-To: <1389887448-4938-1-git-send-email-marcel.a@redhat.com>
On Thu, Jan 16, 2014 at 05:50:45PM +0200, Marcel Apfelbaum wrote:
> patch 1: refactoring
> Addressed Michael S. Tsirkin's prev comments:
> Renamed ssdt_tables to tables to avoid confusion.
> patch 2: resolved iasl crash
> Addressed Michael S. Tsirkin's prev comments:
> Do not assume the order of ssdt tables and
> single ssdt table.
> patch 3: do not fail on asl mismatch
> Rather than failing the test, print a
> warning message including the asl file
> names that can be compared offline.
Thanks, applied.
> Marcel Apfelbaum (3):
> acpi unit-test: renamed ssdt_tables to tables
> acpi unit-test: resolved iasl crash
> acpi unit-test: do not fail on asl mismatch
>
> tests/acpi-test-data/pc/SSDT | Bin 2104 -> 2104 bytes
> tests/acpi-test-data/q35/DSDT | Bin 7344 -> 7344 bytes
> tests/acpi-test.c | 79 ++++++++++++++++++++++++++----------------
> 3 files changed, 50 insertions(+), 29 deletions(-)
>
> --
> 1.8.3.1
prev parent reply other threads:[~2014-01-20 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 15:50 [Qemu-devel] [PATCH 0/3] acpi unit-test: fixes and improvements Marcel Apfelbaum
2014-01-16 15:50 ` [Qemu-devel] [PATCH 1/3] acpi unit-test: renamed ssdt_tables to tables Marcel Apfelbaum
2014-01-16 15:50 ` [Qemu-devel] [PATCH 2/3] acpi unit-test: resolved iasl crash Marcel Apfelbaum
2014-01-16 15:50 ` [Qemu-devel] [PATCH 3/3] acpi unit-test: do not fail on asl mismatch Marcel Apfelbaum
2014-01-20 9:35 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120093549.GA8434@redhat.com \
--to=mst@redhat.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).