From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W5BCQ-0006O4-4q
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 04:31:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W5BCK-00046J-6g
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 04:31:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31882)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W5BCJ-00045O-Vt
	for qemu-devel@nongnu.org; Mon, 20 Jan 2014 04:31:12 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0K9V98L018547
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 20 Jan 2014 04:31:10 -0500
Date: Mon, 20 Jan 2014 11:35:49 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140120093549.GA8434@redhat.com>
References: <1389887448-4938-1-git-send-email-marcel.a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1389887448-4938-1-git-send-email-marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] acpi unit-test: fixes and improvements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Jan 16, 2014 at 05:50:45PM +0200, Marcel Apfelbaum wrote:
> patch 1: refactoring 
>    Addressed Michael S. Tsirkin's prev comments:
>    Renamed ssdt_tables to tables to avoid confusion.
> patch 2: resolved iasl crash
>     Addressed Michael S. Tsirkin's prev comments:
>     Do not assume the order of ssdt tables and
>     single ssdt table.
> patch 3: do not fail on asl mismatch
>     Rather than failing the test, print a 
>     warning message including the asl file 
>     names that can be compared offline.

Thanks, applied.

> Marcel Apfelbaum (3):
>   acpi unit-test: renamed ssdt_tables to tables
>   acpi unit-test: resolved iasl crash
>   acpi unit-test: do not fail on asl mismatch
> 
>  tests/acpi-test-data/pc/SSDT  | Bin 2104 -> 2104 bytes
>  tests/acpi-test-data/q35/DSDT | Bin 7344 -> 7344 bytes
>  tests/acpi-test.c             |  79 ++++++++++++++++++++++++++----------------
>  3 files changed, 50 insertions(+), 29 deletions(-)
> 
> -- 
> 1.8.3.1