From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5SZQ-0001Nd-I1 for qemu-devel@nongnu.org; Mon, 20 Jan 2014 23:04:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5SZK-0006Cy-4v for qemu-devel@nongnu.org; Mon, 20 Jan 2014 23:04:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5SZJ-0006Cs-RP for qemu-devel@nongnu.org; Mon, 20 Jan 2014 23:04:06 -0500 Date: Tue, 21 Jan 2014 12:04:03 +0800 From: Fam Zheng Message-ID: <20140121040403.GK29842@T430.redhat.com> References: <1386862440-8003-1-git-send-email-benoit@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1386862440-8003-1-git-send-email-benoit@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com On Thu, 12/12 16:33, Beno=EEt Canet wrote: > v5: > block empty node names [Kevin] > factorize setting of node-name option [Kevin] > NULL terminate node_name on removal [Kevin] > make query-named-block-nodes return BlockDeviceInfo structure [Eric= ] > Change some doc in query-named-block-nodes [Eric] > Document the choice of the QMP API for node name [Eric] > Use the same authorization as snapshot on block resize [Kevin] > Rebase the series [Kevin] Looks mostly good to me. But the external snapshot permission protection interface looks a bit obsecuer to me. Let's wait for other reviewers' com= ments. Thanks, Fam >=20 > Beno=EEt Canet (7): > block: Add bs->node_name to hold the name of a bs node of the bs > graph. > block: Allow the user to define "node-name" option. > qmp: Add a command to list the named BlockDriverState nodes. > qmp: Allow to change password on named block driver states. > block: Create authorizations mechanism for external snapshot and > resize. > qmp: Allow block_resize to manipulate bs graph nodes. > qmp: Allow to take external snapshots on bs graphs node. >=20 > block.c | 210 ++++++++++++++++++++++++++++++++++++++= +++----- > block/blkverify.c | 2 +- > block/qapi.c | 109 ++++++++++++------------ > blockdev.c | 93 ++++++++++++++++---- > hmp.c | 8 +- > include/block/block.h | 23 +++-- > include/block/block_int.h | 21 ++++- > include/block/qapi.h | 1 + > qapi-schema.json | 48 +++++++++-- > qmp-commands.hx | 78 ++++++++++++++++- > 10 files changed, 471 insertions(+), 122 deletions(-) >=20 > --=20 > 1.8.3.2 >=20