From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5bVJ-00061v-Tc for qemu-devel@nongnu.org; Tue, 21 Jan 2014 08:36:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5bVE-0003QO-S8 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 08:36:33 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:47958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5bVE-0003QB-FY for qemu-devel@nongnu.org; Tue, 21 Jan 2014 08:36:28 -0500 Date: Tue, 21 Jan 2014 14:36:27 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140121133627.GH9834@irqsave.net> References: <1389968119-24771-1-git-send-email-kwolf@redhat.com> <1389968119-24771-14-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1389968119-24771-14-git-send-email-kwolf@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 13/29] block: Introduce bdrv_co_do_pwritev() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com Le Friday 17 Jan 2014 =E0 15:15:03 (+0100), Kevin Wolf a =E9crit : > This is going to become the bdrv_co_do_preadv() equivalent for writes. > In this patch, however, just a function taking byte offsets is created, > it doesn't align anything yet. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) >=20 > diff --git a/block.c b/block.c > index fe55217..328f592 100644 > --- a/block.c > +++ b/block.c > @@ -3016,8 +3016,8 @@ static int coroutine_fn bdrv_aligned_pwritev(Bloc= kDriverState *bs, > /* > * Handle a write request in coroutine context > */ > -static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs, > - int64_t sector_num, int nb_sectors, QEMUIOVector *qiov, > +static int coroutine_fn bdrv_co_do_pwritev(BlockDriverState *bs, > + int64_t offset, unsigned int bytes, QEMUIOVector *qiov, > BdrvRequestFlags flags) > { > int ret; > @@ -3028,21 +3028,33 @@ static int coroutine_fn bdrv_co_do_writev(Block= DriverState *bs, > if (bs->read_only) { > return -EACCES; > } > - if (bdrv_check_request(bs, sector_num, nb_sectors)) { > + if (bdrv_check_byte_request(bs, offset, bytes)) { > return -EIO; > } > =20 > /* throttling disk I/O */ > if (bs->io_limits_enabled) { > - bdrv_io_limits_intercept(bs, nb_sectors, true); > + /* TODO Switch to byte granularity */ > + bdrv_io_limits_intercept(bs, bytes >> BDRV_SECTOR_BITS, true); > } > =20 > - ret =3D bdrv_aligned_pwritev(bs, sector_num << BDRV_SECTOR_BITS, > - nb_sectors << BDRV_SECTOR_BITS, qiov, f= lags); > + ret =3D bdrv_aligned_pwritev(bs, offset, bytes, qiov, flags); > =20 > return ret; > } > =20 > +static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs, > + int64_t sector_num, int nb_sectors, QEMUIOVector *qiov, > + BdrvRequestFlags flags) > +{ > + if (nb_sectors < 0 || nb_sectors > (INT_MAX >> BDRV_SECTOR_BITS)) = { > + return -EINVAL; > + } > + > + return bdrv_co_do_pwritev(bs, sector_num << BDRV_SECTOR_BITS, > + nb_sectors << BDRV_SECTOR_BITS, qiov, fl= ags); > +} > + > int coroutine_fn bdrv_co_writev(BlockDriverState *bs, int64_t sector_n= um, > int nb_sectors, QEMUIOVector *qiov) > { > --=20 > 1.8.1.4 >=20 >=20 Reviewed-by: Benoit Canet