From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45630)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5cK3-0001Jl-L0
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 09:29:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5cJy-00034I-42
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 09:28:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37597)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5cJx-00034D-Rn
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 09:28:54 -0500
Date: Tue, 21 Jan 2014 15:28:49 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140121142849.GL3307@dhcp-200-207.str.redhat.com>
References: <1386862440-8003-1-git-send-email-benoit@irqsave.net>
	<1386862440-8003-8-git-send-email-benoit@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1386862440-8003-8-git-send-email-benoit@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V5 7/7] qmp: Allow to take external
 snapshots on bs graphs node.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit@irqsave.net>
Cc: famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com

Am 12.12.2013 um 16:34 hat Beno=EEt Canet geschrieben:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  blockdev.c       | 55 ++++++++++++++++++++++++++++++++++++++++++++++++=
-------
>  hmp.c            |  4 +++-
>  qapi-schema.json | 13 ++++++++++---
>  qmp-commands.hx  | 11 ++++++++++-
>  4 files changed, 71 insertions(+), 12 deletions(-)

> diff --git a/qapi-schema.json b/qapi-schema.json
> index 3977619..d7afb69 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1759,18 +1759,25 @@
>  ##
>  # @BlockdevSnapshot
>  #
> -# @device:  the name of the device to generate the snapshot from.
> +# Either @device or @node-name must be set but not both.
> +#
> +# @device: #optional the name of the device to generate the snapshot f=
rom.
> +#
> +# @node-name: #optional graph node name to generate the snapshot from =
(Since 2.0)
>  #
>  # @snapshot-file: the target of the new image. A new file will be crea=
ted.
>  #
> +# @snapshot-node-name: #optional the graph node name of the new image =
(Since 2.0)
> +#

I think we should document how this plays together with snapshot-file,
format and mode.

Perhaps this is actually different enough that it would justify creating
a new QMP command 'blockdev-snapshot' that never creates image files but
only ever takes existing nodes. The implementation of 'blockdev-snapshot-
sync' could then become a wrapper around it.

>  # @format: #optional the format of the snapshot image, default is 'qco=
w2'.
>  #
>  # @mode: #optional whether and how QEMU should create a new image, def=
ault is
>  #        'absolute-paths'.
>  ##
>  { 'type': 'BlockdevSnapshot',
> -  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
> -            '*mode': 'NewImageMode' } }
> +  'data': { '*device': 'str', '*node-name': 'str',
> +            'snapshot-file': 'str', '*snapshot-node-name': 'str',
> +            '*format': 'str', '*mode': 'NewImageMode' } }
> =20
>  ##
>  # @BlockdevSnapshotInternal

Kevin