From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5dNj-0002Mo-5X for qemu-devel@nongnu.org; Tue, 21 Jan 2014 10:36:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5dNd-0000Wk-1P for qemu-devel@nongnu.org; Tue, 21 Jan 2014 10:36:51 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:47980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5dNc-0000WK-O0 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 10:36:44 -0500 Date: Tue, 21 Jan 2014 16:36:42 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140121153642.GM9834@irqsave.net> References: <1386862440-8003-1-git-send-email-benoit@irqsave.net> <20140121143309.GM3307@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140121143309.GM3307@dhcp-200-207.str.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com Le Tuesday 21 Jan 2014 =E0 15:33:09 (+0100), Kevin Wolf a =E9crit : > Am 12.12.2013 um 16:33 hat Beno=EEt Canet geschrieben: > > v5: > > block empty node names [Kevin] > > factorize setting of node-name option [Kevin] > > NULL terminate node_name on removal [Kevin] > > make query-named-block-nodes return BlockDeviceInfo structure [Er= ic] > > Change some doc in query-named-block-nodes [Eric] > > Document the choice of the QMP API for node name [Eric] > > Use the same authorization as snapshot on block resize [Kevin] > > Rebase the series [Kevin] > >=20 > > Beno=EEt Canet (7): > > block: Add bs->node_name to hold the name of a bs node of the bs > > graph. > > block: Allow the user to define "node-name" option. > > qmp: Add a command to list the named BlockDriverState nodes. > > qmp: Allow to change password on named block driver states. > > block: Create authorizations mechanism for external snapshot and > > resize. > > qmp: Allow block_resize to manipulate bs graph nodes. > > qmp: Allow to take external snapshots on bs graphs node. >=20 > One more general question: Now that we have node names, should > bdrv_file_open() use node names rather than device names for references= ? > (Well, no, come to think of it, it's not really a question, but more of > a request ;-)) :) I don't understand what you mean: I don't see any reference to device_nam= e in bdrv_file_open only one in bdrv_open which is used in a printf. Best regards Beno=EEt >=20 > Kevin