From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on
Date: Tue, 21 Jan 2014 17:30:52 +0100 [thread overview]
Message-ID: <20140121163052.GR3307@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <52DE9D8F.8020309@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
Am 21.01.2014 um 17:17 hat Eric Blake geschrieben:
> On 01/21/2014 09:14 AM, Jeff Cody wrote:
> > Important note: this patch should only be applied after patch
> > "block: do not allow read-only=on and snapshot=on to be used together"
> >
> > Now that 'read-only=on' and 'snapshot=on' are not allowed together,
> > forcing open_flags to have BDRV_O_RDWR set is redundant code, and can be
> > removed. This is because unless read-only=on is specified, the image
> > will always be opened with BDRV_O_RDWR set.
> >
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > ---
> > block.c | 7 -------
> > 1 file changed, 7 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks, applied to the block branch.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-01-21 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 16:14 [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on Jeff Cody
2014-01-21 16:17 ` Eric Blake
2014-01-21 16:30 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121163052.GR3307@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).