From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5eE9-000381-QD for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:31:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5eE3-0002OH-SA for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:31:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5eE3-0002Mh-Iv for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:30:55 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0LGUr76021976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Jan 2014 11:30:54 -0500 Date: Tue, 21 Jan 2014 17:30:52 +0100 From: Kevin Wolf Message-ID: <20140121163052.GR3307@dhcp-200-207.str.redhat.com> References: <0715fccd414384a7c177ff93e976a40b2e938650.1390320839.git.jcody@redhat.com> <52DE9D8F.8020309@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <52DE9D8F.8020309@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Jeff Cody , qemu-devel@nongnu.org, stefanha@redhat.com --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 21.01.2014 um 17:17 hat Eric Blake geschrieben: > On 01/21/2014 09:14 AM, Jeff Cody wrote: > > Important note: this patch should only be applied after patch > > "block: do not allow read-only=3Don and snapshot=3Don to be used toget= her" > >=20 > > Now that 'read-only=3Don' and 'snapshot=3Don' are not allowed together, > > forcing open_flags to have BDRV_O_RDWR set is redundant code, and can be > > removed. This is because unless read-only=3Don is specified, the image > > will always be opened with BDRV_O_RDWR set. > >=20 > > Signed-off-by: Jeff Cody > > --- > > block.c | 7 ------- > > 1 file changed, 7 deletions(-) >=20 > Reviewed-by: Eric Blake Thanks, applied to the block branch. Kevin --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJS3qC8AAoJEH8JsnLIjy/Whs8P/3fDpGxzy+oB03ykUVpk9ie7 5gFI59So7/lIfiNqa1V3Sx205ceQGjRlgBPn5ecASAl+H6IImzU1G04pSpUofADI Eh5uTgeKEFnqSzB4d2TlgNThu5NHlaiKbGdiUbOF5IiYlMD9eH2k9LJ5CQz7ION5 f+BYqL8yFUdqcWLsPrzsbfGxYx3VtwF3C7waMrujepgd+JLUcgsxpS0xCE6aBqNC 6Lg3vULJsey3TMSpbDOpzx9pNUf8f0EjH6Ujn+b3Vcn5QaAdtXQUn8pDwLOwn4jr xQI94s7nFGTf4YdyuY5XDwM3kT/gkb4jIRvL35um1DrHldTtIGw6zaZIYM1QYXX5 1pvLNIKP67dZ8J+f7gbUDmD2mj6o6ZcbwGOiC/Ptb2Q2uGoBLbryV3WkCY42JdS1 uWny3xb97I/tUacJZlONb4b39jCb6h0UiSHAVIG7GGsH7Fi3Os69WuWoFe40rXAR ziTfZlfNgMpyWUlSd8DsU6NPo2AoJ2NWeUpuVp4EYMhSveIIrMsR218rPsmkd3le 4PLlWZMkcfafhhyd79JH4eV5awfljpsoLiKh02DDQdE+CDHsAhYZbSZ6En1fxVr4 u4AfWzCTHvRYdfkTL4ySe+EFgAqUIHD9lQ6xhKgINGaRUJtIM9BZraKgmnsRFBPk gJi9Irz0oJDrzQvg2e8G =iSrD -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--