From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39340)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5yj2-0003Si-MK
	for qemu-devel@nongnu.org; Wed, 22 Jan 2014 09:24:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5yix-0006E7-KR
	for qemu-devel@nongnu.org; Wed, 22 Jan 2014 09:24:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:10353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W5yix-0006E0-C5
	for qemu-devel@nongnu.org; Wed, 22 Jan 2014 09:24:11 -0500
Date: Wed, 22 Jan 2014 15:24:09 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140122142409.GL10065@dhcp-200-207.str.redhat.com>
References: <1390227608-7225-1-git-send-email-cyliu@suse.com>
	<1390227608-7225-13-git-send-email-cyliu@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1390227608-7225-13-git-send-email-cyliu@suse.com>
Subject: Re: [Qemu-devel] [v19 12/25] qed.c: replace QEMUOptionParameter
	with QemuOpts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>
Cc: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>, qemu-devel@nongnu.org, stefanha@redhat.com

Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben:
> qed.c: replace QEMUOptionParameter with QemuOpts
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> ---
>  block/qed.c |   89 +++++++++++++++++++++++++++++------------------------------
>  block/qed.h |    3 +-
>  2 files changed, 45 insertions(+), 47 deletions(-)

> diff --git a/block/qed.h b/block/qed.h
> index 5d65bea..b024751 100644
> --- a/block/qed.h
> +++ b/block/qed.h
> @@ -43,7 +43,7 @@
>   *
>   * All fields are little-endian on disk.
>   */
> -
> +#define  QED_DEFAULT_CLUSTER_SIZE  65536
>  enum {
>      QED_MAGIC = 'Q' | 'E' << 8 | 'D' << 16 | '\0' << 24,
>  
> @@ -69,7 +69,6 @@ enum {
>       */
>      QED_MIN_CLUSTER_SIZE = 4 * 1024, /* in bytes */
>      QED_MAX_CLUSTER_SIZE = 64 * 1024 * 1024,
> -    QED_DEFAULT_CLUSTER_SIZE = 64 * 1024,
>  
>      /* Allocated clusters are tracked using a 2-level pagetable.  Table size is
>       * a multiple of clusters so large maximum image sizes can be supported

What is this hunk good for?

Kevin