From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5zkR-0003vZ-BG for qemu-devel@nongnu.org; Wed, 22 Jan 2014 10:29:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5zkH-0004sC-VS for qemu-devel@nongnu.org; Wed, 22 Jan 2014 10:29:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5zkH-0004ry-Nk for qemu-devel@nongnu.org; Wed, 22 Jan 2014 10:29:37 -0500 Date: Wed, 22 Jan 2014 13:29:17 -0200 From: Marcelo Tosatti Message-ID: <20140122152917.GA22855@amt.cnet> References: <1390224336-27009-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390224336-27009-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH uq/master] kvm: always update the MPX model specific register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Liu Jinsong , qemu-devel@nongnu.org, kvm@vger.kernel.org On Mon, Jan 20, 2014 at 02:25:36PM +0100, Paolo Bonzini wrote: > The original patch from Liu Jinsong restricted them to reset or full > state updates, but that's unnecessary (and wrong) since the BNDCFGS > MSR has no side effects. Why is it necessary to save/restore BNDCFGS MSR on states other than FULL and RESET? > Cc: Liu Jinsong > Signed-off-by: Paolo Bonzini > --- > target-i386/kvm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 221c8a0..d34981f 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -1161,6 +1161,9 @@ static int kvm_put_msrs(X86CPU *cpu, int level) > kvm_msr_entry_set(&msrs[n++], MSR_IA32_MISC_ENABLE, > env->msr_ia32_misc_enable); > } > + if (has_msr_bndcfgs) { > + kvm_msr_entry_set(&msrs[n++], MSR_IA32_BNDCFGS, env->msr_bndcfgs); > + } > #ifdef TARGET_X86_64 > if (lm_capable_kernel) { > kvm_msr_entry_set(&msrs[n++], MSR_CSTAR, env->cstar); > @@ -1224,9 +1227,6 @@ static int kvm_put_msrs(X86CPU *cpu, int level) > if (cpu->hyperv_vapic) { > kvm_msr_entry_set(&msrs[n++], HV_X64_MSR_APIC_ASSIST_PAGE, 0); > } > - if (has_msr_bndcfgs) { > - kvm_msr_entry_set(&msrs[n++], MSR_IA32_BNDCFGS, env->msr_bndcfgs); > - } > > /* Note: MSR_IA32_FEATURE_CONTROL is written separately, see > * kvm_put_msr_feature_control. */ > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html