From: Kevin Wolf <kwolf@redhat.com>
To: Zhang Min <rudy.zhangmin@huawei.com>
Cc: Fam Zheng <famz@redhat.com>,
"Wangting (Kathy)" <kathy.wangting@huawei.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Qinling <mail.qinling@huawei.com>,
"Chentao (Boby)" <boby.chen@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Wubin (H)" <wu.wubin@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v2] drive mirror:fix memory leak
Date: Thu, 23 Jan 2014 11:51:46 +0100 [thread overview]
Message-ID: <20140123105146.GD8474@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <52E0CBD4.5090306@huawei.com>
Am 23.01.2014 um 08:59 hat Zhang Min geschrieben:
>
> In the function mirror_iteration() -> qemu_iovec_init(),
> it allocates memory for op->qiov.iov, when the write request calls back,
> but in the function mirror_iteration_done(), it only frees the op,
> not free the op->qiov.iov, so this causes memory leak.
>
> It should use qemu_iovec_destroy() to free op->qiov.
>
> Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2014-01-23 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 7:59 [Qemu-devel] [PATCH v2] drive mirror:fix memory leak Zhang Min
2014-01-23 10:51 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123105146.GD8474@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=boby.chen@huawei.com \
--cc=famz@redhat.com \
--cc=kathy.wangting@huawei.com \
--cc=mail.qinling@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rudy.zhangmin@huawei.com \
--cc=stefanha@gmail.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).