From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W6HtC-0005uR-3i
	for qemu-devel@nongnu.org; Thu, 23 Jan 2014 05:52:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W6Ht7-0003Og-9S
	for qemu-devel@nongnu.org; Thu, 23 Jan 2014 05:52:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33119)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1W6Ht7-0003OA-1R
	for qemu-devel@nongnu.org; Thu, 23 Jan 2014 05:51:57 -0500
Date: Thu, 23 Jan 2014 11:51:46 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140123105146.GD8474@dhcp-200-207.str.redhat.com>
References: <52E0CBD4.5090306@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52E0CBD4.5090306@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v2] drive mirror:fix memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Min <rudy.zhangmin@huawei.com>
Cc: Fam Zheng <famz@redhat.com>, "Wangting (Kathy)" <kathy.wangting@huawei.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Qinling <mail.qinling@huawei.com>, "Chentao (Boby)" <boby.chen@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>, "Wubin (H)" <wu.wubin@huawei.com>

Am 23.01.2014 um 08:59 hat Zhang Min geschrieben:
> 
> In the function mirror_iteration() -> qemu_iovec_init(),
> it allocates memory for op->qiov.iov, when the write request calls back,
> but in the function mirror_iteration_done(), it only frees the op,
> not free the op->qiov.iov, so this causes memory leak.
> 
> It should use qemu_iovec_destroy() to free op->qiov.
> 
> Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com>

Thanks, applied to the block branch.

Kevin