From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6IrO-0000X0-5K for qemu-devel@nongnu.org; Thu, 23 Jan 2014 06:54:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6IrF-0006Vu-GY for qemu-devel@nongnu.org; Thu, 23 Jan 2014 06:54:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6IrF-0006Us-8f for qemu-devel@nongnu.org; Thu, 23 Jan 2014 06:54:05 -0500 Date: Thu, 23 Jan 2014 19:53:59 +0800 From: Amos Kong Message-ID: <20140123115359.GA14603@amosk.info> References: <1390462216-23273-1-git-send-email-akong@redhat.com> <87fvof7yvv.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fvof7yvv.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] qapi: store raw expressions to QAPISchema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, mdroth@linux.vnet.ibm.com On Thu, Jan 23, 2014 at 11:53:24AM +0100, Markus Armbruster wrote: > Amos Kong writes: > > > After cleaning up the comments of qapi-schema.json file, we get > > an range of raw expressions, they are also converted to ordered > > dictionaries. > > > > This patch just addes a member to QAPISchema to store the raw > > expressions. > > > > Actually this patch was split from QMP introspection patchset, > > it's no longer needed in that patchset. I would like to post > > this patch singly, we can apply it if it's useful. > > It'll be useful when it has a user, or if it eases maintenance. Neither > is obvious to me at a quick, superficial glance. The patch didn't change original parse logic, it just repeatedly save each single clear schema to a list in existed loop. I think it's easy to maintain. In the introspection patchset, I want to pass raw json expressions to C code by a head file, then convert the json expressions to qobject, then ... At the end, I generated a expression with more metadata when visit Ordered Dictionaries. So raw expressions were not used. > Happy to hear a more verbose explanation of what raw expressions might > be good for. -- Amos.