From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together
Date: Fri, 24 Jan 2014 14:33:19 +0100 [thread overview]
Message-ID: <20140124133319.GH3342@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <2fb3ea05d2e1ee06d578a0f2c53f56df1661401c.1389726691.git.jcody@redhat.com>
Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben:
> Having both read-only=on and snapshot=on together does not make sense;
> currently, the read-only argument is effectively ignored for the
> temporary snapshot. To prevent confusion, disallow the usage of both
> 'snapshot=on' and 'read-only=on'.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
This breaks in a surprising way:
$ softmmu/qemu-system-x86_64 -drive file=~/images/hd.img,snapshot=on
... works fine ...
$ qemu-system-x86_64 -drive file=~/images/hd.img -snapshot
qemu-system-x86_64: invalid option combination: read-only and snapshot
qemu-iotests case 051 catches this. I'll have to remove this patch and
the follow-up from the queue for now.
Kevin
next prev parent reply other threads:[~2014-01-24 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 19:12 [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together Jeff Cody
2014-01-14 19:30 ` Eric Blake
2014-01-16 7:00 ` Stefan Hajnoczi
2014-01-16 9:39 ` Kevin Wolf
2014-01-16 19:20 ` Jeff Cody
2014-01-17 17:01 ` Kevin Wolf
2014-01-24 13:33 ` Kevin Wolf [this message]
2014-01-24 13:48 ` Jeff Cody
2014-03-12 11:16 ` Kevin Wolf
2014-03-14 12:40 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124133319.GH3342@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).