qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: benoit.canet@irqsave.net, famz@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 0/3] block: commits of snapshots larger than backing files
Date: Fri, 24 Jan 2014 16:14:51 +0100	[thread overview]
Message-ID: <20140124151451.GL3342@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <cover.1390570808.git.jcody@redhat.com>

Am 24.01.2014 um 15:02 hat Jeff Cody geschrieben:
> Changes, v4->v5
> 
> Patch 1/3: Update ret in bdrv_commit() (Kevin)
> Patch 2/3: None
> Patch 3/3: None
> 
> [...]
> 
> If a snapshot is larger than a backing file, then the offline bdrv_commit and
> the live active layer commit will fail with an i/o error (usually).  A live
> commit of a non-active layer will complete successfully, as it runs
> bdrv_truncate() on the backing image to resize it to the larger size.
> 
> For both bdrv_commit() and commit_active_start(), this series will resize
> the underlying base image if needed.  If the resize fails, an error will
> be returned.
> 
> 
> Jeff Cody (3):
>   block: resize backing file image during offline commit, if necessary
>   block: resize backing image during active layer commit, if needed
>   block: update block commit documentation regarding image truncation
> 
>  block.c          | 28 +++++++++++++++++++++++++---
>  block/mirror.c   | 38 ++++++++++++++++++++++++++++++++++++++
>  hmp-commands.hx  |  5 +++++
>  qapi-schema.json |  7 +++++++
>  qemu-img.texi    |  7 ++++++-
>  qmp-commands.hx  | 39 +++++++++++++++++++++++++++++++++++++++
>  6 files changed, 120 insertions(+), 4 deletions(-)

Thanks, applied to the block branch.

Kevin

      parent reply	other threads:[~2014-01-24 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 14:02 [Qemu-devel] [PATCH v5 0/3] block: commits of snapshots larger than backing files Jeff Cody
2014-01-24 14:02 ` [Qemu-devel] [PATCH v5 1/3] block: resize backing file image during offline commit, if necessary Jeff Cody
2014-01-24 14:02 ` [Qemu-devel] [PATCH v5 2/3] block: resize backing image during active layer commit, if needed Jeff Cody
2014-01-24 14:02 ` [Qemu-devel] [PATCH v5 3/3] block: update block commit documentation regarding image truncation Jeff Cody
2014-01-24 15:14 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140124151451.GL3342@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=benoit.canet@irqsave.net \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).