From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6iTH-0001BT-Tx for qemu-devel@nongnu.org; Fri, 24 Jan 2014 10:15:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6iTB-0000Cz-V0 for qemu-devel@nongnu.org; Fri, 24 Jan 2014 10:15:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6iTB-0000Cv-Ms for qemu-devel@nongnu.org; Fri, 24 Jan 2014 10:14:57 -0500 Date: Fri, 24 Jan 2014 16:14:51 +0100 From: Kevin Wolf Message-ID: <20140124151451.GL3342@dhcp-200-207.str.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v5 0/3] block: commits of snapshots larger than backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: benoit.canet@irqsave.net, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 24.01.2014 um 15:02 hat Jeff Cody geschrieben: > Changes, v4->v5 > > Patch 1/3: Update ret in bdrv_commit() (Kevin) > Patch 2/3: None > Patch 3/3: None > > [...] > > If a snapshot is larger than a backing file, then the offline bdrv_commit and > the live active layer commit will fail with an i/o error (usually). A live > commit of a non-active layer will complete successfully, as it runs > bdrv_truncate() on the backing image to resize it to the larger size. > > For both bdrv_commit() and commit_active_start(), this series will resize > the underlying base image if needed. If the resize fails, an error will > be returned. > > > Jeff Cody (3): > block: resize backing file image during offline commit, if necessary > block: resize backing image during active layer commit, if needed > block: update block commit documentation regarding image truncation > > block.c | 28 +++++++++++++++++++++++++--- > block/mirror.c | 38 ++++++++++++++++++++++++++++++++++++++ > hmp-commands.hx | 5 +++++ > qapi-schema.json | 7 +++++++ > qemu-img.texi | 7 ++++++- > qmp-commands.hx | 39 +++++++++++++++++++++++++++++++++++++++ > 6 files changed, 120 insertions(+), 4 deletions(-) Thanks, applied to the block branch. Kevin