From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7wee-0000zj-FZ for qemu-devel@nongnu.org; Mon, 27 Jan 2014 19:35:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7weZ-0007Sw-Fq for qemu-devel@nongnu.org; Mon, 27 Jan 2014 19:35:52 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:48484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7weZ-0007Sq-5m for qemu-devel@nongnu.org; Mon, 27 Jan 2014 19:35:47 -0500 Date: Tue, 28 Jan 2014 01:35:45 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140128003545.GB15867@irqsave.net> References: <376a25d5e5f1fa1b1c68b60f749138b3b018ec9d.1390856648.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <376a25d5e5f1fa1b1c68b60f749138b3b018ec9d.1390856648.git.jcody@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] block: remove QED .bdrv_make_empty implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Le Monday 27 Jan 2014 =E0 16:09:12 (-0500), Jeff Cody a =E9crit : > The QED .bdrv_make_empty() implementation does nothing but return > -ENOTSUP, which causes problems in bdrv_commit(). Since the function > stub exists for QED, it is called, which then always returns an error. >=20 > The proper way to not support an optional driver function stub is to > just not implement it, so let's remove the stub. >=20 > Signed-off-by: Jeff Cody > --- > block/qed.c | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/block/qed.c b/block/qed.c > index 694e6e2..b9ca7ac 100644 > --- a/block/qed.c > +++ b/block/qed.c > @@ -731,11 +731,6 @@ static int64_t coroutine_fn bdrv_qed_co_get_block_= status(BlockDriverState *bs, > return cb.status; > } > =20 > -static int bdrv_qed_make_empty(BlockDriverState *bs) > -{ > - return -ENOTSUP; > -} > - > static BDRVQEDState *acb_to_s(QEDAIOCB *acb) > { > return acb->common.bs->opaque; > @@ -1617,7 +1612,6 @@ static BlockDriver bdrv_qed =3D { > .bdrv_create =3D bdrv_qed_create, > .bdrv_has_zero_init =3D bdrv_has_zero_init_1, > .bdrv_co_get_block_status =3D bdrv_qed_co_get_block_status, > - .bdrv_make_empty =3D bdrv_qed_make_empty, > .bdrv_aio_readv =3D bdrv_qed_aio_readv, > .bdrv_aio_writev =3D bdrv_qed_aio_writev, > .bdrv_co_write_zeroes =3D bdrv_qed_co_write_zeroes, > --=20 > 1.8.3.1 >=20 >=20 Reviewed-by: Benoit Canet