qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PULL 3/5] add optional 2nd stage initialization to -object/object-add commands
Date: Tue, 28 Jan 2014 12:49:02 -0500	[thread overview]
Message-ID: <20140128124902.27259d5b@redhat.com> (raw)
In-Reply-To: <52E7EA40.9030609@redhat.com>

On Tue, 28 Jan 2014 10:34:56 -0700
Eric Blake <eblake@redhat.com> wrote:

> On 01/28/2014 10:27 AM, Luiz Capitulino wrote:
> > From: Igor Mammedov <imammedo@redhat.com>
> > 
> > Introduces USER_CREATABLE interface that must be implemented by
> > objects which are designed to created with -object CLI option or
> > object-add QMP command.
> > 
> 
> > +/**
> > + * UserCreatableClass:
> > + * @parent_class: the base class
> > + * @complete: callback to be called after @obj's properties are set.
> > + *
> > + * Interface is designed to work with -object/object-add/object_add
> > + * commands.
> > + * Interface in mandatory for objects that are designed to be user
> 
> s/in/is/
> 
> > + * creatable (i.e. -object/object-add/object_add, will accept only
> > + * objects that inherit this interface).
> > + *
> > + * iInterface also provides an optional ability to do the second
> 
> s/iInterface/Interface/
> 
> > + * stage * initialization of the object after its properties were
> 
> Spurious *

I've fixed those typos and already updated my tree. Thanks Eric.

  reply	other threads:[~2014-01-28 17:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 17:27 [Qemu-devel] [PULL 0/5] QMP queue Luiz Capitulino
2014-01-28 17:27 ` [Qemu-devel] [PULL 1/5] object_add: consolidate error handling Luiz Capitulino
2014-01-28 17:27 ` [Qemu-devel] [PULL 2/5] vl.c: -object: don't ignore duplicate 'id' Luiz Capitulino
2014-01-28 17:27 ` [Qemu-devel] [PULL 3/5] add optional 2nd stage initialization to -object/object-add commands Luiz Capitulino
2014-01-28 17:34   ` Eric Blake
2014-01-28 17:49     ` Luiz Capitulino [this message]
2014-01-28 17:27 ` [Qemu-devel] [PULL 4/5] virtio_rng: replace custom backend API with UserCreatable.complete() callback Luiz Capitulino
2014-01-28 17:27 ` [Qemu-devel] [PULL 5/5] monitor: Cleanup mon->outbuf on write error Luiz Capitulino
2014-02-01 23:41 ` [Qemu-devel] [PULL 0/5] QMP queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140128124902.27259d5b@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).