From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, imain@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd()
Date: Tue, 28 Jan 2014 18:09:39 +0100 [thread overview]
Message-ID: <20140128170939.GC1993@stefanha-thinkpad> (raw)
In-Reply-To: <1390794497-26281-6-git-send-email-famz@redhat.com>
On Mon, Jan 27, 2014 at 11:48:11AM +0800, Fam Zheng wrote:
> + pstrcpy(bs->backing_file, sizeof(bs->backing_file), backing_hd->filename);
> + pstrcpy(bs->backing_format, sizeof(bs->backing_file),
> + backing_hd->drv ? backing_hd->drv->format_name : "");
> + bdrv_ref(bs->backing_hd);
> +
> + pstrcpy(bs->backing_file, sizeof(bs->backing_file),
> + bs->backing_hd->file->filename);
> + pstrcpy(bs->backing_format, sizeof(bs->backing_format),
> + bs->backing_hd->drv->format_name);
This is redundant, you already have the same above?
next prev parent reply other threads:[~2014-01-28 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 3:48 [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 01/11] block: Add BlockOpType enum Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 02/11] block: Introduce op_blockers to BlockDriverState Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 03/11] block: Replace in_use with operation blocker Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 04/11] block: Move op_blocker check from block_job_create to its caller Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd() Fam Zheng
2014-01-28 17:09 ` Stefan Hajnoczi [this message]
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 06/11] block: Add backing_blocker in BlockDriverState Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 07/11] block: Parse "backing" option to reference existing BDS Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 08/11] block: Support dropping active in bdrv_drop_intermediate Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 09/11] stream: Use bdrv_drop_intermediate and drop close_unused_images Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 10/11] qmp: Add command 'blockdev-backup' Fam Zheng
2014-01-27 3:48 ` [Qemu-devel] [PATCH v12 11/11] block: Allow backup on referenced named BlockDriverState Fam Zheng
2014-01-28 14:31 ` [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Stefan Hajnoczi
2014-01-28 16:57 ` Ian Main
2014-01-29 8:44 ` Stefan Hajnoczi
2014-01-29 10:23 ` Kevin Wolf
2014-01-29 4:35 ` Fam Zheng
2014-01-28 17:22 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128170939.GC1993@stefanha-thinkpad \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).