From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W8CB8-0006cu-DP
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 12:10:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W8CB1-00070W-1A
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 12:10:26 -0500
Received: from mail-ea0-f179.google.com ([209.85.215.179]:58559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W8CB0-00070Q-QK
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 12:10:18 -0500
Received: by mail-ea0-f179.google.com with SMTP id q10so307151ead.24
	for <qemu-devel@nongnu.org>; Tue, 28 Jan 2014 09:09:43 -0800 (PST)
Date: Tue, 28 Jan 2014 18:09:39 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140128170939.GC1993@stefanha-thinkpad>
References: <1390794497-26281-1-git-send-email-famz@redhat.com>
	<1390794497-26281-6-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1390794497-26281-6-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com

On Mon, Jan 27, 2014 at 11:48:11AM +0800, Fam Zheng wrote:
> +    pstrcpy(bs->backing_file, sizeof(bs->backing_file), backing_hd->filename);
> +    pstrcpy(bs->backing_format, sizeof(bs->backing_file),
> +            backing_hd->drv ? backing_hd->drv->format_name : "");
> +    bdrv_ref(bs->backing_hd);
> +
> +    pstrcpy(bs->backing_file, sizeof(bs->backing_file),
> +            bs->backing_hd->file->filename);
> +    pstrcpy(bs->backing_format, sizeof(bs->backing_format),
> +            bs->backing_hd->drv->format_name);

This is redundant, you already have the same above?