From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8VSI-00009N-Hy for qemu-devel@nongnu.org; Wed, 29 Jan 2014 08:45:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8VSC-0002qZ-If for qemu-devel@nongnu.org; Wed, 29 Jan 2014 08:45:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8VSC-0002qP-74 for qemu-devel@nongnu.org; Wed, 29 Jan 2014 08:45:20 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0TDjIxw007946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jan 2014 08:45:18 -0500 Date: Wed, 29 Jan 2014 14:45:16 +0100 From: Kevin Wolf Message-ID: <20140129134516.GJ2726@dhcp-200-207.str.redhat.com> References: <1390762963-25538-1-git-send-email-mreitz@redhat.com> <1390762963-25538-9-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390762963-25538-9-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 08/10] block: Reuse bs->options setting from bdrv_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 26.01.2014 um 20:02 hat Max Reitz geschrieben: > Setting bs->options in bdrv_file_open() is not necessary if it is > already done in bdrv_open(). > > Signed-off-by: Max Reitz Perhaps squash this into patch 7? Because now the reference is created by bdrv_open() instead of bdrv_file_open(). Also my suggestion in a reply to a patch earlier in this series (keeping all option-related code at one place), probably means that it all needs to be done together (or immediately after) handling the NULL options case. Kevin