* Re: [Qemu-devel] [PATCH] block/iscsi: always fill bs->bl.opt_transfer_length
[not found] <1390997015-19609-1-git-send-email-pl@kamp.de>
@ 2014-01-29 15:36 ` Benoît Canet
2014-02-03 15:57 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Benoît Canet @ 2014-01-29 15:36 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, benoit.canet, ronniesahlberg, qemu-devel, stefanha
Le Wednesday 29 Jan 2014 à 13:03:35 (+0100), Peter Lieven a écrit :
> the opt_transfer_length has nothing to do with logical
> block provisioning stuff so always copy it from
> the block limits VPD page.
>
> Reported-By: Benoit Canet <benoit@irqsave.net>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/iscsi.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 38b07f8..3c0b728 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1331,10 +1331,9 @@ static int iscsi_refresh_limits(BlockDriverState *bs)
> }
> bs->bl.write_zeroes_alignment = sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
> iscsilun);
> -
> - bs->bl.opt_transfer_length = sector_lun2qemu(iscsilun->bl.opt_xfer_len,
> - iscsilun);
> }
> + bs->bl.opt_transfer_length = sector_lun2qemu(iscsilun->bl.opt_xfer_len,
> + iscsilun);
> return 0;
> }
>
> --
> 1.7.9.5
>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] block/iscsi: always fill bs->bl.opt_transfer_length
2014-01-29 15:36 ` [Qemu-devel] [PATCH] block/iscsi: always fill bs->bl.opt_transfer_length Benoît Canet
@ 2014-02-03 15:57 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2014-02-03 15:57 UTC (permalink / raw)
To: Benoît Canet; +Cc: ronniesahlberg, Peter Lieven, qemu-devel, stefanha
Am 29.01.2014 um 16:36 hat Benoît Canet geschrieben:
> Le Wednesday 29 Jan 2014 à 13:03:35 (+0100), Peter Lieven a écrit :
> > the opt_transfer_length has nothing to do with logical
> > block provisioning stuff so always copy it from
> > the block limits VPD page.
> >
> > Reported-By: Benoit Canet <benoit@irqsave.net>
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> > block/iscsi.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/block/iscsi.c b/block/iscsi.c
> > index 38b07f8..3c0b728 100644
> > --- a/block/iscsi.c
> > +++ b/block/iscsi.c
> > @@ -1331,10 +1331,9 @@ static int iscsi_refresh_limits(BlockDriverState *bs)
> > }
> > bs->bl.write_zeroes_alignment = sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
> > iscsilun);
> > -
> > - bs->bl.opt_transfer_length = sector_lun2qemu(iscsilun->bl.opt_xfer_len,
> > - iscsilun);
> > }
> > + bs->bl.opt_transfer_length = sector_lun2qemu(iscsilun->bl.opt_xfer_len,
> > + iscsilun);
> > return 0;
> > }
> >
> > --
> > 1.7.9.5
> >
> Reviewed-by: Benoit Canet <benoit@irqsave.net>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-03 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1390997015-19609-1-git-send-email-pl@kamp.de>
2014-01-29 15:36 ` [Qemu-devel] [PATCH] block/iscsi: always fill bs->bl.opt_transfer_length Benoît Canet
2014-02-03 15:57 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).