From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2
Date: Wed, 29 Jan 2014 16:46:57 +0100 [thread overview]
Message-ID: <20140129154657.GE3079@irqsave.net> (raw)
In-Reply-To: <1391009634-21107-1-git-send-email-stefanha@redhat.com>
Le Wednesday 29 Jan 2014 à 16:33:54 (+0100), Stefan Hajnoczi a écrit :
> The 071 test is designed for IMGFMT=qcow2 because it uses the l2_load
> blkdebug event. Its output filtering also assumes that IMGFMT is not
> raw since 071.out contains "format=raw" but IMGFMT=raw would filter the
> output to "format=IMGFMT".
>
> Perhaps the test case can be rewritten to be more generic, but for now
> let's document that it was only supposed to work with qcow2.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/qemu-iotests/071 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071
> index 2a22546..dbc07c6 100755
> --- a/tests/qemu-iotests/071
> +++ b/tests/qemu-iotests/071
> @@ -38,7 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> . ./common.rc
> . ./common.filter
>
> -_supported_fmt generic
> +_supported_fmt qcow2
> _supported_proto generic
> _supported_os Linux
>
> --
> 1.8.5.3
>
>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
next prev parent reply other threads:[~2014-01-29 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 15:33 [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2 Stefan Hajnoczi
2014-01-29 15:46 ` Benoît Canet [this message]
2014-01-31 12:19 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129154657.GE3079@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).