* [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2
@ 2014-01-29 15:33 Stefan Hajnoczi
2014-01-29 15:46 ` Benoît Canet
2014-01-31 12:19 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-01-29 15:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Max Reitz
The 071 test is designed for IMGFMT=qcow2 because it uses the l2_load
blkdebug event. Its output filtering also assumes that IMGFMT is not
raw since 071.out contains "format=raw" but IMGFMT=raw would filter the
output to "format=IMGFMT".
Perhaps the test case can be rewritten to be more generic, but for now
let's document that it was only supposed to work with qcow2.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/qemu-iotests/071 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071
index 2a22546..dbc07c6 100755
--- a/tests/qemu-iotests/071
+++ b/tests/qemu-iotests/071
@@ -38,7 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
. ./common.rc
. ./common.filter
-_supported_fmt generic
+_supported_fmt qcow2
_supported_proto generic
_supported_os Linux
--
1.8.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2
2014-01-29 15:33 [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2 Stefan Hajnoczi
@ 2014-01-29 15:46 ` Benoît Canet
2014-01-31 12:19 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Benoît Canet @ 2014-01-29 15:46 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, qemu-devel, Max Reitz
Le Wednesday 29 Jan 2014 à 16:33:54 (+0100), Stefan Hajnoczi a écrit :
> The 071 test is designed for IMGFMT=qcow2 because it uses the l2_load
> blkdebug event. Its output filtering also assumes that IMGFMT is not
> raw since 071.out contains "format=raw" but IMGFMT=raw would filter the
> output to "format=IMGFMT".
>
> Perhaps the test case can be rewritten to be more generic, but for now
> let's document that it was only supposed to work with qcow2.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/qemu-iotests/071 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071
> index 2a22546..dbc07c6 100755
> --- a/tests/qemu-iotests/071
> +++ b/tests/qemu-iotests/071
> @@ -38,7 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> . ./common.rc
> . ./common.filter
>
> -_supported_fmt generic
> +_supported_fmt qcow2
> _supported_proto generic
> _supported_os Linux
>
> --
> 1.8.5.3
>
>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2
2014-01-29 15:33 [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2 Stefan Hajnoczi
2014-01-29 15:46 ` Benoît Canet
@ 2014-01-31 12:19 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-01-31 12:19 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, qemu-devel, Max Reitz
On Wed, Jan 29, 2014 at 04:33:54PM +0100, Stefan Hajnoczi wrote:
> The 071 test is designed for IMGFMT=qcow2 because it uses the l2_load
> blkdebug event. Its output filtering also assumes that IMGFMT is not
> raw since 071.out contains "format=raw" but IMGFMT=raw would filter the
> output to "format=IMGFMT".
>
> Perhaps the test case can be rewritten to be more generic, but for now
> let's document that it was only supposed to work with qcow2.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/qemu-iotests/071 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-31 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-29 15:33 [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2 Stefan Hajnoczi
2014-01-29 15:46 ` Benoît Canet
2014-01-31 12:19 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).