From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8YiO-0007GU-H3 for qemu-devel@nongnu.org; Wed, 29 Jan 2014 12:14:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8YiE-0007fx-FZ for qemu-devel@nongnu.org; Wed, 29 Jan 2014 12:14:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8YiE-0007fL-6L for qemu-devel@nongnu.org; Wed, 29 Jan 2014 12:14:06 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0THE59l016322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jan 2014 12:14:05 -0500 Date: Wed, 29 Jan 2014 12:14:02 -0500 From: Jeff Cody Message-ID: <20140129171402.GD11249@localhost.localdomain> References: <1391015108-31808-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391015108-31808-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/vhdx: Error checking fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Wed, Jan 29, 2014 at 06:05:08PM +0100, Markus Armbruster wrote: > Errors are inadvertently ignored in a few places. Has always been > broken. Spotted by Coverity. > > Signed-off-by: Markus Armbruster > --- > block/vhdx-log.c | 4 ++-- > block/vhdx.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/block/vhdx-log.c b/block/vhdx-log.c > index 8c9ae0d..02755b8 100644 > --- a/block/vhdx-log.c > +++ b/block/vhdx-log.c > @@ -965,8 +965,8 @@ static int vhdx_log_write(BlockDriverState *bs, BDRVVHDXState *s, > cpu_to_le32s((uint32_t *)(buffer + 4)); > > /* now write to the log */ > - vhdx_log_write_sectors(bs, &s->log, §ors_written, buffer, > - desc_sectors + sectors); > + ret = vhdx_log_write_sectors(bs, &s->log, §ors_written, buffer, > + desc_sectors + sectors); > if (ret < 0) { > goto exit; > } > diff --git a/block/vhdx.c b/block/vhdx.c > index 9ee0a61..55689cf 100644 > --- a/block/vhdx.c > +++ b/block/vhdx.c > @@ -374,7 +374,7 @@ static int vhdx_update_header(BlockDriverState *bs, BDRVVHDXState *s, > inactive_header->log_guid = *log_guid; > } > > - vhdx_write_header(bs->file, inactive_header, header_offset, true); > + ret = vhdx_write_header(bs->file, inactive_header, header_offset, true); > if (ret < 0) { > goto exit; > } > @@ -1810,13 +1810,13 @@ static int vhdx_create(const char *filename, QEMUOptionParameter *options, > creator = g_utf8_to_utf16("QEMU v" QEMU_VERSION, -1, NULL, > &creator_items, NULL); > signature = cpu_to_le64(VHDX_FILE_SIGNATURE); > - bdrv_pwrite(bs, VHDX_FILE_ID_OFFSET, &signature, sizeof(signature)); > + ret = bdrv_pwrite(bs, VHDX_FILE_ID_OFFSET, &signature, sizeof(signature)); > if (ret < 0) { > goto delete_and_exit; > } > if (creator) { > - bdrv_pwrite(bs, VHDX_FILE_ID_OFFSET + sizeof(signature), creator, > - creator_items * sizeof(gunichar2)); > + ret = bdrv_pwrite(bs, VHDX_FILE_ID_OFFSET + sizeof(signature), > + creator, creator_items * sizeof(gunichar2)); > if (ret < 0) { > goto delete_and_exit; > } > -- > 1.8.1.4 > Reviewed-by: Jeff Cody