qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: pbonzini@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org,
	mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Name threads
Date: Thu, 30 Jan 2014 13:03:26 +0000	[thread overview]
Message-ID: <20140130130325.GA2655@work-vm> (raw)
In-Reply-To: <52EA4CB0.6090607@redhat.com>

* Eric Blake (eblake@redhat.com) wrote:
> On 01/30/2014 03:20 AM, Dr. David Alan Gilbert (git) wrote:
> 
> > The first patch converts --name to use QemuOpts, a side effect of this is that
> >   --name process=foo,bar
> > no longer allows a process name of 'foo,bar', since ',' is a separator.
> 
> Just to make sure I understand correctly, am I right that if you want a
> process name of 'foo,bar' you can still invoke --name process=foo,,bar ?

Much to my surprise, apparently so:

dgilbert 18228 18104 37 13:01 pts/12   00:00:03 ./bin/qemu-system-x86_64 --name process=foo,,bar
[dgilbert@dgilbert-t530 try-thread]$ cat /proc/18228/comm 
foo,bar

(I hadn't realised QemuOpts did that)

> Libvirt will probably not be using this option, since it is not intended
> to be a stable API, but I can definitely see the value of it for
> debugging :)

Great :-)

Dave

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

      reply	other threads:[~2014-01-30 13:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 10:20 [Qemu-devel] [PATCH v2 0/3] Name threads Dr. David Alan Gilbert (git)
2014-01-30 10:20 ` [Qemu-devel] [PATCH v2 1/3] Rework --name to use QemuOpts Dr. David Alan Gilbert (git)
2014-02-09  8:43   ` Laszlo Ersek
2014-02-10 10:03     ` Dr. David Alan Gilbert
2014-02-10 16:12       ` Laszlo Ersek
2014-02-11  9:07         ` Paolo Bonzini
2014-02-11 13:30           ` Eric Blake
2014-01-30 10:20 ` [Qemu-devel] [PATCH v2 2/3] Add 'debug-threads' suboption to --name Dr. David Alan Gilbert (git)
2014-02-09  9:08   ` Laszlo Ersek
2014-02-10 10:16     ` Dr. David Alan Gilbert
2014-02-10 16:14       ` Laszlo Ersek
2014-01-30 10:20 ` [Qemu-devel] [PATCH v2 3/3] Add a 'name' parameter to qemu_thread_create Dr. David Alan Gilbert (git)
2014-02-09  9:37   ` Laszlo Ersek
2014-02-10  9:49     ` Dr. David Alan Gilbert
2014-01-30 12:59 ` [Qemu-devel] [PATCH v2 0/3] Name threads Eric Blake
2014-01-30 13:03   ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140130130325.GA2655@work-vm \
    --to=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).