From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9GLt-0000nK-Je for qemu-devel@nongnu.org; Fri, 31 Jan 2014 10:50:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9GLn-0002Ru-LH for qemu-devel@nongnu.org; Fri, 31 Jan 2014 10:49:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9GLn-0002Rg-DE for qemu-devel@nongnu.org; Fri, 31 Jan 2014 10:49:51 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0VFno2A006067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 31 Jan 2014 10:49:50 -0500 Date: Fri, 31 Jan 2014 16:00:32 +0100 From: Stefan Hajnoczi Message-ID: <20140131150032.GB15009@stefanha-thinkpad.redhat.com> References: <1391097445-23100-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391097445-23100-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] block: handle "rechs" and "large" translation options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Thu, Jan 30, 2014 at 04:57:25PM +0100, Paolo Bonzini wrote: > Sure, CHS translation is an obscure topic, and legacy options for > hard-disk geometries are obscure as well. But since QEMU does nothing > with it except telling the BIOS, and since there "large" and "rechs" > are listed in the enums, parsing them seems to be the bare minimum. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 4 ++++ > vl.c | 22 ++++++++++++++++------ > 2 files changed, 20 insertions(+), 6 deletions(-) Acked-by: Stefan Hajnoczi Feel free to squash into your other series. (Please consider doing a separate patch with the documentation updates I mentioned in response to v1.)