From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9Yzf-0007Nc-Bk for qemu-devel@nongnu.org; Sat, 01 Feb 2014 06:44:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9Yza-0006WT-9b for qemu-devel@nongnu.org; Sat, 01 Feb 2014 06:44:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9Yza-0006WN-10 for qemu-devel@nongnu.org; Sat, 01 Feb 2014 06:44:10 -0500 Date: Sat, 1 Feb 2014 12:44:05 +0100 From: Martin Kletzander Message-ID: <20140201114404.GA11061@wheatley> References: <52EBDB6A.8000800@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <52EBDB6A.8000800@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qmp: expose list of supported character device backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Markus Armbruster , qemu-devel@nongnu.org, Anthony Liguori , Luiz Capitulino --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 31, 2014 at 10:20:42AM -0700, Eric Blake wrote: > On 01/31/2014 09:49 AM, Martin Kletzander wrote: > > Introduce 'query-chardev-backends' QMP command which lists all > > supported character device backends. > > > > Signed-off-by: Martin Kletzander > > --- > > v2: > > - Version changed from "1.8.0" to "2.0" > > > > qapi-schema.json | 22 ++++++++++++++++++++++ > > qemu-char.c | 19 +++++++++++++++++++ > > qmp-commands.hx | 41 +++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 82 insertions(+) > > > + > > +-> { "execute": "query-chardev-backends" } > > +<- { > > + "return":[ > > + { > > + "name":"udp", > > + }, > > Sorry for not noticing earlier, but this is not valid JSON. Lose the > trailing comma after each "name":"value", since the last element in a > JSON struct is not permitted to have a comma. > At first, I had it as a list of strings, maybe that's why I left it there by mistake, hopefully v3 will be OK. Thanks for the review, Martin > > + { > > + "name":"tcp", > > + }, > > + { > > + "name":"unix", > > + }, > > + { > > + "name":"spiceport", > > + } > > With that change to all four spots, > > Reviewed-by: Eric Blake > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJS7N4EAAoJEAgfwp8kF4bdal0QALTKic0eupxIKfe/U5Q4brBh cvrUKKrgn1/CS37I7AjvNS0zaxc8fchMrjRFLNrh6BMjI1iU0KVV1AVgdRthuqKD 7sK6U/e7kYW0UKCu3Dzgeh/jLJJm9x2JpEBQx32mprxi77soH546eQo3ZpzK1sgF eZOcvDD0nQ5qSm8rFmR3YaEusU1hN7TWbrhSxneemETiJx6HzBPdgU3BqePNUirk 5QU/E4M6u6CS9zukKn/HXkp41Y6x4yOYe7C3c/Csum9n13X9rbhEtRBMY/YL5VKy vdy5s66QAODp/wEOPZPAO0S8ArinakspYjgZixc0BOkUg56pU9SVB4Y2ctzVXisT Z+1ETA0o7kiJLhcjBVABYx/plWRuQ1MrgUivPV9cXhHyeILqy3oqlEpglA6aIhGp DN9BHEP/MG/PbQpkGJ3D3DzOH4c8OFOxoqNY3QBhiyqXTUy4UAlYCTGlBbiymG83 wshl3yiUmTDrVh3SJnPP5J+814oHtk+IaIyFqp6l6JsuPGeAkiIuUR/BQq4Dvv/c bioUwyCA6NcseJdRyJkcjSb7h76LXs9hKJN89DnopLCqagJ8qDoAVXyGbkuAZHBQ 5umaMsM9YcKbAXH5fKsvPNERau8bnKWgMsa1eLj1zYeRWaIChuofFZRAWsEGVy2F rcJlPwHgZOb0MU9Jvfcm =KMeK -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--