From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9cXk-00075P-SS for qemu-devel@nongnu.org; Sat, 01 Feb 2014 10:31:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9cXf-0007yW-H2 for qemu-devel@nongnu.org; Sat, 01 Feb 2014 10:31:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9cXf-0007yI-9Y for qemu-devel@nongnu.org; Sat, 01 Feb 2014 10:31:35 -0500 Date: Sat, 1 Feb 2014 23:31:33 +0800 From: Fam Zheng Message-ID: <20140201153133.GC6756@T430.redhat.com> References: <1390984843-2101-1-git-send-email-famz@redhat.com> <1390984843-2101-4-git-send-email-famz@redhat.com> <52E90BB6.1070503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52E90BB6.1070503@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: Allow caller to disable underscore convertion for qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , =?iso-8859-1?Q?Beno=EEt?= Canet , qemu-devel@nongnu.org, Stefan Hajnoczi On Wed, 01/29 07:09, Eric Blake wrote: > On 01/29/2014 01:40 AM, Fam Zheng wrote: > > s/convertion/conversion/ in the subject > > > QMP command "block_set_io_throttle" expects underscores in parameters > > instead of dashes: {iops,bps}_{rd,wr,max}. > > > > Add optional argument conv_keys (defaults to True, backward compatible), > > it will be used in IO throttling test case. > > > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-iotests/iotests.py | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > You know, it might be nice to get the '-'/'_' looseness into QMP itself > when invoked via JSON strings over the monitor, rather than just the > testsuite wrapper, since we're already inconsistent in several commands. > But that's a bigger project for another day. > I agree. Let's stick to this now and leave the loosing in QMP for later. Fam