From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1W9hE6-000491-Cf
	for qemu-devel@nongnu.org; Sat, 01 Feb 2014 15:31:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1W9hE1-0004RX-Gg
	for qemu-devel@nongnu.org; Sat, 01 Feb 2014 15:31:42 -0500
Received: from ssl.serverraum.org ([88.198.40.39]:55263)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1W9hE1-0004RJ-As
	for qemu-devel@nongnu.org; Sat, 01 Feb 2014 15:31:37 -0500
From: Michael Walle <michael@walle.cc>
Date: Sat, 1 Feb 2014 21:31:32 +0100
References: <1390246471-25167-1-git-send-email-michael@walle.cc>
	<1390246471-25167-10-git-send-email-michael@walle.cc>
	<CAFEAcA8Knj_qEKfy6RLoCsqQPVvvBWDE7whbiedu8tGOU8-14A@mail.gmail.com>
In-Reply-To: <CAFEAcA8Knj_qEKfy6RLoCsqQPVvvBWDE7whbiedu8tGOU8-14A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201402012131.32819.michael@walle.cc>
Subject: Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on
	stderr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@amazon.com>

Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell:
> On 20 January 2014 19:34, Michael Walle <michael@walle.cc> wrote:
> > Do not use qemu_log().
> > 
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > ---
> > 
> >  hw/misc/lm32_sys.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c
> > index 8176cdb..6af0cca 100644
> > --- a/hw/misc/lm32_sys.c
> > +++ b/hw/misc/lm32_sys.c
> > @@ -80,7 +80,7 @@ static void sys_write(void *opaque, hwaddr addr,
> > 
> >      case R_PASSFAIL:
> >          s->regs[addr] = value;
> >          testname = (char *)s->testname;
> > 
> > -        qemu_log("TC  %-32s %s\n", testname, (value) ? "FAILED" : "OK");
> > +        fprintf(stderr, "TC  %-32s %s\n", testname, (value) ? "FAILED" :
> > "OK");
> > 
> >          break;
> 
> This looks wrong to me -- devices shouldn't print to stderr, ideally.

lm32_sys is actually no real device. it is just used for unit testing.

-michael